dapr / js-sdk Goto Github PK

TypeScript typings would be very helpful (must-have) for TypeScript developers.

It is possible to automatically generate typings from .proto - there are several utilities for that purpose available, e.g. https://github.com/improbable-eng/ts-protoc-gen .

this package [https://www.npmjs.com/package/grpc] is deprecated, I have problems installing it, and it is necessary to update to grpc.js.

Describe the proposal

For Typescript users, we need to publish the @types definitions to npm.

Hello all,

currently we have the problem that the module grpc is not found at runtime. This is probably because the module is deprecated and has been replaced with @grpc/grpc-js.

If I change the dependencies and the requiere statement accordingly our application works again.

here the original error message =>
Cannot find module 'node-pre-gyp/lib/pre-binding'
Require stack:

• /usr/src/app/node_modules/grpc/src/grpc_extension.js
• /usr/src/app/node_modules/grpc/src/client_interceptors.js
• /usr/src/app/node_modules/grpc/src/client.js
• /usr/src/app/node_modules/grpc/index.js
• /usr/src/app/node_modules/dapr-client/src/dapr/proto/runtime/v1/dapr_grpc_pb.js
• /usr/src/app/node_modules/dapr-client/src/index.js
• /usr/src/app/node_modules/adapter_sdk/api/services/EventPublisher.js....

Can you please fix this quickly?

Best Regard
Patrick Campergue

We strive to have easy to use examples that help everyone. For this issue we are looking for an example that describes how to use actors for HTTP.

Describe the proposal

Add a script file to generate gRPC client code/stubs from dapr proto files by installing necessary tooling, plugins for JavaScript.

Describe the proposal

Automate npm package publish.

Release Note

RELEASE NOTE: Automate npm package publish

Describe the proposal

• Fix the github workflow to publish the package to npm registry
• Add NPM_AUTH_TOKEN to github secrets for this repo

Edit: publish to github releases as well

NPM Publish should get automated, building the SDK on main merge and publishing a new version to the NPM Registry.

• Find out who owns the NPM Org
• Setup GitHub Actions build script

Expected Behavior

Examples should run if you follow the instructions.

Actual Behavior

Examples don't run. The compiler gives errors about missing imports.

Steps to Reproduce the Problem

Run the examples.

NodeJS doesn't find the library from the import of @dapr/js-sdk. This should be changed to ../../../../build to reference the correct folder.

After changing this, more import errors occur, this time due to protos not having been compiled. An extra step should be added to the instructions, saying to run ./build.sh, which compiles the protos.

Expected Behavior

The declaration / import of the grpc in the dapr js-sdk TypeScript example come from the grpc library itself not from dapr import.

Correct declaration / import:

import grpc from 'grpc';

Actual Behavior

The example extract the grpc from the dapr module

Steps to Reproduce the Problem

When compiling the example the following error happens:

error TS2339: Property 'grpc' does not exist on type 'typeof import("js-sdk/node_modules/dapr-client/src/main")'.

27 var grpc = dapr.grpc;
                   ~~~~


Found 1 error.

Describe the proposal

The testing and building process could use some simplification to lay foundations for CI/CD process

Actors should be supported

We strive to have easy to use examples that help everyone. For this issue we are looking for an example that describes how to use Secrets for HTTP and gRPC.

We strive to have easy to use examples that help everyone. For this issue we are looking for an example that describes how to use Method Invocation for HTTP and gRPC.

State APIs should support sending metadata in the request.

Dapr runtime issue Reference : dapr/dapr#1909 . Update proto files.

Describe the proposal

Update auto-generated js sdk for changes in proto files(multi store feature)

Describe the proposal

Update proto files for 0.8.0 release

Describe the proposal

regen proto client

Describe the proposal

Consider adding examples on how to use the JS SDK for each of the supported Building Blocks, e.g how to use the JS SDK for Service Invocation.

These examples will provide clarity on how to use the SDK. Additionally, we can raise visibility into the SDK by linking to the examples from each Building Block overview page.

Describe the proposal

It looks like this repo has received minimal love, but I did want to propose a change that I think would make this lib much friendlier. The protoc generated javascript is....not great. From the pre-property getXyz and setXyz, to the bizzare naming, this lib is not very Javascript like.

I propose switching to something like protobuf.js which has a reasonably active implementation and generates much friendlier code by default.

Expected Behavior

Reminder tests should correctly succeed

Actual Behavior

There is an issue that appears that reminders are being fired multiple times in the tests, this might be due to IDs being similar

Steps to Reproduce the Problem

Just want to know if this feature (being able to write actors in javascript) along with pub sub dapr/dapr#501 is there in the roadmap.

Describe the proposal

The proto files in dapr/dapr are renamed and files are moved to new folder (runtime). Update protobuf.sh file to work with these changes.

Describe the proposal

DAPR supports invoked services signifying errors using their response status code. https://docs.dapr.io/reference/api/service_invocation_api/

The invoker server currently sends a status 200 response when the callback is called. To support errors, some controls will need to be added to set a custom response status code.

On the client side, the return value will need to show this returned status code.

Describe the proposal

Runtime has added support for ISO 8601 intervals for reminders as per dapr/dapr#2513.
Make changes to SDK to support accordingly

Expected Behavior

We are using DaprClient to publish message to kafka using kafka pubsub.
We are receiving http request in our application via dapr side car and in the application we are publishing the message to kafka pub sub using DaprClient. DaprClient should publish the message to kafka pub sub when rate of publishing to kafka is increased.

Actual Behavior

DaprClient throws error when the rate at which we publish the message increases.

We get an error from DarpClient
ERROR 14:43:36:777 error publishing topic through dapr: FetchError: request to http://localhost:3500/v1.0/publish/kafka-pubsub/request-topic failed, reason: connect ECONNREFUSED 127.0.0.1:3500
== APP == at ClientRequest.

When the rate at which we are publishing the message to kafka pub sub increase than DaprClient throws error saying connection refused.

Steps to Reproduce the Problem

We are using DaprCLient and publishing using below

 async publishMessage(topic: string, message: PubSubMessage): Promise<void> {
    try {
      await this.client.pubsub.publish(this.pubsubName, topic, message);
    } catch (error: any) {
      logger.error("error publishing topic through dapr: ", error);
    }
  }

yaml for binding is

apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: messagebus
spec:
  type: pubsub.kafka
  version: v1
  metadata:
  - name: brokers # Required. Kafka broker connection setting
    value: "localhost:9092"
  - name: consumerGroup # Optional. Used for input bindings.
    value: "group1"
  - name: clientID # Optional. Used as client tracing ID by Kafka brokers.
    value: "my-dapr-app-id"
  - name: authRequired # Required.
    value: "false"

It is running on Mac M1

Expected Behavior

https://www.npmjs.com/package/dapr-client

1. The README page is to be displayed on the registry page.
2. Links of repo and issues has to be navigated to https://github.com/dapr/js-sdk/

Actual Behavior

1. No Readme page
2. Broken repo link

Steps to Reproduce the Problem

Navigate to https://www.npmjs.com/package/dapr-client

Expected Behavior

The example is not working and running into an error.

Actual Behavior

Executing the example results in an error:

`$ node app.js
[...]/app.js:13
event.setPubsubName('pubsub');
^

TypeError: event.setPubsubName is not a function
at Object. ([...]/js-sdk/examples/simple/app.js:13:7)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)`

Steps to Reproduce the Problem

• Clone the repository
• go to ./examples/simple
• execute npm install
• start the sample by running node app.js
  (the "main" entry in the package.json points to an index.js that does not exist)

Describe the proposal

Add support for actor reentrancy

Needs to check if Node.js requires this seeing it's single threaded nature?

Describe the proposal

Proto clients are being updated by this PR. Make necessary changes to examples.

Ask your question here

The grpc max message size limit is 4MB now, and I wonder how to setup this limit. Thanks.

https://github.com/dapr/js-sdk/blob/8bfda5b1e6ea46a8ca02ac22481e3ffec0dde4bd/src/types/KeyValue.type.ts

should be changed to string, any instead of string, string

Describe the proposal

Upgrade proto to the latest

Ask your question here

As dapr now is on 1.0, what are your plans for the js-sdk. Are there any reasons not also releasing a final major version?

Describe the proposal

Ref dapr/dapr#2864

Release Note

RELEASE NOTE: ADD support domain socket.

Expected Behavior

Actual Behavior

TypeError: dapr.InvokeRequest is not a constructor

Steps to Reproduce the Problem

import { Any } from 'google-protobuf/google/protobuf/any_pb';
import * as dapr from 'dapr-client';
import grpc from 'grpc';

export default class App {
    daprClient: dapr.dapr_grpc.DaprClient;

    constructor() {
        this.daprClient = new dapr.dapr_grpc.DaprClient(
            `localhost:50002`, grpc.credentials.createInsecure());
    }

    getUser() {
            return new Promise((resolve, reject) => {
                let invokeServiceRequest = new dapr.dapr_pb.InvokeServiceRequest();
                invokeServiceRequest.setId('app01');
                let invokeRequest = new dapr.InvokeRequest();
                invokeRequest.setContentType('application/json');
                invokeRequest.setMethod('users/12345');
                let httpExtension = new dapr.HTTPExtension();
                httpExtension.setVerb(dapr.HTTPExtension.Verb.GET);
                invokeRequest.setHttpExtension(httpExtension);
                invokeServiceRequest.setMessage(invokeRequest);
                this.daprClient.invokeService(invokeServiceRequest, (error, response) => {
                    if (error) {
                        reject(error);
                    }
                    else {
                        resolve(response.getData());
                    }
                });
            });
        }
}

Hi All!

As discussed I would love to contribute an API spec proposal for the Dapr JS SDK :) It's a bit opiniated, but I hope it might lead to a discussion to see what can be improved.

Some of the key elements:

• Typescript
• Class based
• Extensibility

Usage example:

// Initialize Express
const app = express();

// Initialize dapr service
const daprService = new Dapr("YOUR_URL", "YOUR_PORT");

// State Management
const res = await daprService.state.get("my-store-name", "key");
const res = await daprService.state.save("my-store-name", [{ key: "value" }]);

// Create binding (receive / send)
const res = await daprService.binding.send("my-queue", { hello: "world" });

daprService.binding.receive(app, "my-queue", bindingInput.bind(this));

async function bindingInput(data) {
    console.log("Receive Input");
    console.log(data);
}

// Create Pub Sub
const res = await daprService.pubsub.publish("my-pubsub", "my-topic", { hello: "world" });

daprService.pubsub.receive(app, "my-pubsub", "my-topic", bindingInput.bind(this));

async function bindingInput(data) {
    console.log("Receive Input");
    console.log(data);
}

// Invoke
const res = await daprService.invoke.invoke("app-id", "method-name", { hello: "world" });

await daprService.invoke.register(app, "my-endpoint", invokedEndpoint.bind(this));

async function invokedEndpoint(data) {
    console.log("Receive Input");
    console.log(data);
}

Some of the code I wrote for this can be found here: https://github.com/XavierGeerinck/PublicProjects/tree/master/JS/Dapr/AutoScalingHTTP/Gateway/src/API/dapr this has not been tested yet though... so some work is left to be done.

Describe the proposal

Set up GitHub Actions workflow for build and publish pkg

• Create Workflow for build
• Create workflow for publishing pkg

Expected Behavior

Tracing should be supported as described https://docs.dapr.io/developing-applications/building-blocks/observability/tracing-overview/#:~:text=Dapr%20uses%20the%20standard%20W3C,Dapr%20creates%20a%20new%20one.

Describe the proposal

Update proto for 0.10.0 and support multi pubsub

Describe the proposal

The Dapr runtime follows a certain release cadence. It might be interesting to follow this release versioning:

Advantages:

• Easier to know which SDK is compatible with which runtime version

Disadvantages:

• Requires more updates and releases and strictly follow the Dapr release schedule (note: we do have milestone plannings that should be followed, so might be possible)

Describe the proposal

https://nvd.nist.gov/vuln/detail/CVE-2020-15228 advises that set-env and add-path are not secure, so they will be disabled very shortly on workflows. This PR changes set-env to the recommended upgrade.

Github workflows deprecating the "set-env" call to set environment variables.
Make use of the new method to modify env vars.

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Promise support is a must have and is definitely preferred over callbacks.

Describe the proposal

Replace deprecated cli options and k8s annotations with new ones. Parent epic.

hi everyone. does any documentation exist that describes how to use actors in the js sdk ?

Expected Behavior

When triggering a reminder on an actor that does not have reminders implemented, the code should not crash

Actual Behavior

Code crashes with error:

{"error":"ACTOR_METHOD_DOES_NOT_EXIST","errorMsg":"The actor method 'receiveReminder' does not exist on DemoActorReminderImpl"}

Describe the proposal

DAPR supports distributed tracing by sending a trace context in the request/response headers. To support this, js-sdk needs to send this trace context, if it's present in the request, in the response headers.

The trace context should also be available outside the library (for example, to the invoker server callback), so it can be used in other operations related to the request.

We strive to have easy to use examples that help everyone. For this issue we are looking for an example that describes how to use Pub/Sub for HTTP and gRPC.