dapphub / ds-token Goto Github PK

test issue

symbol & name of the token should be defined as a string, but you defined as byte32, which breaks the erc20 interface.

so when I use the standard erc20 interface to unpack dstoken, I get errors

abi: cannot marshal in to go slice: offset 35000214728014336407470934256024915466671168103574785725052718905953538277408 would go over slice boundary (len=32)

you can refer to this token contract(mkr): https://etherscan.io/address/0x9f8f72aa9304c8b593d555f12ef6589cc3a579a2#code

What is the supported solc version?

https://github.com/nexusdev/ds-burner/issues/1

The website link on this repo (https://github.com/dapphub/ds-token) is broken. We link out to this page from the ethereum.org developer docs. Could you confirm the status of this project?

I was about to do a pull request with fixed contract paths that I noticed some contracts such as auth.sol is missing from the files.

some other contracts have wrong paths, e.g /token/ and /data/ directories

• from front-end.sol

import 'auth.sol';
import 'token/controller.sol';
import 'token/event_callback.sol';
import 'token/token.sol';

• from controller.sol

 import 'auth.sol';
import 'data/approval_db.sol';
import 'data/balance_db.sol';
import 'token/erc20.sol';
import 'token/event_callback.sol';
import 'token/frontend.sol';
import 'token/token.sol';

import 'util/safety.sol';

• controller which lets you use a https://github.com/nexusdev/ds-whitelist to restrict balance holders
• controller which lets you use a https://github.com/nexusdev/ds-roles to restrict balance holderns

Hi, Is there any plan to support ERC223?

I think there's an edge case: INT_MIN/-1

start -> flow

stoppable -> stops, make ds-stops

approve -> ?

transfer -> handled by push

transferFrom -> move, also pull for natural case

(keep erc20 names for compatability. ew!)

I'm wondering if the use of the words 'debit' and 'credit' in the definitions of 'mint' and 'burn' are intentionally used in the technical accounting sense of the term or not. The current wording implies that accounts are credit-normal (like a liability) and the total supply is debit-normal (like an asset). If that's the case, I think that that should be made explicit in the readme and the verbiage on

#### `mint`
increase (credit) tokens at an address whilst simultaneously increasing (debiting) `totalSupply`  
(requires auth) 

#### `burn` 
decrease (debit) tokens at an address whilst simultaneously decreasing (crediting) `totalSupply`  
(requires auth)

I compiled with solc:0.5.12 successfully and failed to run dapp create with nor string or bytes32

it shows the error:

hevm: could not parse abi argument: 0x494f550000000000000000000000000000000000000000000000000000000000 : string

I'm sure I'm doing something wrong... but not sure what.

Trying to compile token.sol and it fails at the import statements.

Hi,

The function DSToken.transferFrom emits an event Transfer, which is not documented in the README doc.

A potential fix could be adding "Emits a Transfer event" to the README doc.

Furthermore, function DSToken.transfer calls the function transferFrom. So it also emits the event Transfer.

A potential fix could be also adding "Emits a Transfer event" to this function in the README doc.

Could you please check it?

Thanks.