danwsong / gemuboi-js Goto Github PK

Generating waveforms takes up almost half of the processing time. Optimizations are likely necessary. One such optimization might be to reduce the sound clock frequency to reduce the number of samples generated (this can be replaced with loops, or just dropping samples altogether).

main.js is incredibly bloated right now. It would probably be best to split into separate files for things like Sound, Display, etc. Even classes like Sound might benefit from further splitting, like a class for each sound channel.

There are a number of numeric constants that are not attached to any variable. Readability, and ability to quickly change their values, would likely improve by assigning these values to a variable instead.