danwahlin / angularoverlay Goto Github PK

Do you have any interest in publishing this package through Bower? (or is it there and I can't find it?)

I have no idea how publication works but would be willing to help with the legwork if needed.

Looks great. But please give an equivalent Angular 2 version please. Looking forward to learn from it.

Hi,

The directive works great, but recently I had an issue with the fact that the $http service was not calling the error callback. Always the success callback, even when I was returning status codes 400, 404...etc.

For instance I was calling $http.post(...) in one of my controllers and returning HTTP status code 400 (bad request). However the success callback was always fired, never the error callback. Until I disabled the overlay directive.

It works well when I modify the code for the httpInterceptor.responseError = function(...);

httpInterceptor.responseError = function(rejection) {
processResponse();
return $q.reject(rejection);
};

It was not rejecting the promise on response errors.

Regards,