danielsaidi / sheeeeeeeeet Goto Github PK

If say I need to center option text in an item, how to do that ?
In addition, how to change color of the option text ?

appearance does not seem to work for color change:

        clearAction.appearance.textColor = .red
        clearAction.appearance.tintColor = .red

And there seems no options for do text adjustment :(

Is there a way to detect the Danger button was pressed? My code is below.

 func createStandardActionSheet(indexPath: IndexPath) -> ActionSheet {
        let title = ActionSheetTitle(title: "Select an option")
        let item1 = ActionSheetItem(title: "View Code", value: "1", image: UIImage(named: "baseline_pageview_black_18pt"))
        let item2 = ActionSheetItem(title: "Edit Profile", value: "2", image: UIImage(named: "baseline_create_black_18pt"))
        let item3 = ActionSheetItem(title: "Share Profile", value: "3", image: UIImage(named: "baseline_share_black_18pt"))
        let deleteButton = ActionSheetDangerButton(title: "Delete Profile")
        let button = ActionSheetOkButton(title: "Cancel")
        return ActionSheet(items: [title, item1, item2, item3, deleteButton, button]) { _, item in
            guard let value = item.value as? String else { return }
            if value == "1" {
                //do stuff
            } else if value == "2" {
               //do stuff
            } else if value == "3" {
                //do stuff
            } 
        }
    }

The standard presenter handles scrolling incorrectly, where a sheet scrolls when it shouldn't and behaves strange after orientation change.

Hello
When we have lots of options (for example 15), in iPad (in my tests, iPad Pro 9.7 inch), tableView.isScrollEnabled is false, and users can NOT scroll tableView and select their choice.

How can I fix this?

I'm trying to present a Sheeeeeeeeet from the example code:

        let title = ActionSheetTitle(title: "Select an option")
        let item1 = ActionSheetItem(title: "Option 1", value: "1", image: image1)
        let item2 = ActionSheetItem(title: "Option 2", value: "2", image: image2)
        let button = ActionSheetOkButton(title: "OK")
        let action = ActionSheet(items: [title, item1, item2, button]) { (_, item) in
            guard let value = item.value as? String else { return }
            // You now have the selected value, e.g. "1". The ok button uses `true`.
        }
        action.present(in: self, from: view)

Unfortunately, this is what I get:

Not only are the items not visible, but the Sheeeeeeeeet doesn't seem to respect the width of the device.

Tapping any of the items doesn't do anything. Tapping outside the Sheeeeeeeeet doesn't do anything as well. This happens on my iPhone 8+ as well, not only in the simulator.

The example project is working as intended though!

Hi, thanks for you job, it's compatible with @objc ?

Cheers

There are a bunch of appearance tests to write:

• The entire Appearance namespace
• The appearance handling of all item classes

These parts of Sheeeeeeeeet should be covered in tests.

The default iPhone action sheet presenter correctly disposes the action sheet when a user taps outside the action sheet. The iPad popover presenter, however, does not.

I need to execute my own actions when a ActionSheetCustomButton is tapped (opening a modal). At the moment I have to set the tapBehavior for the button to .none otherwise the default value .dismiss causes the sheet to close when tapped however .none seems to disable the highlight color and that's not what I want.

The selection highlight is preserved during dismissal when selecting a new item in a popover.

Hi Daniel,

Presenting an ActionSheet, while SplitViewing a second App results in a black Background ( / the underlying Views being removed !? )

How to reproduce:

1. Run SheeeeeeeeetExample Project on an iPad with SplitView capability
2. Open a second App and activate SplitView
3. Try any ActionSheet
4. Black Background

I uploaded some Images / Screenshots for you:
https://imgur.com/a/UEY85Zw

I hope you can identify the Problem faster than I can

Love your Pod ❤️
Dominic

Sheeeeeeeeet honors the bottom safe area on an iPhone X, but it does not honor the horizontal safe areas, which causes the action sheets to extend beyond the notch in landscape.

The action sheet class is highly untested at the moment. It should be covered in tests.

Hi again,
Wondering what's the envisioned way, if any, for dismissing ActionSheet from a custom view.

Thanks

Creating and presenting an action sheet section contains code which seems to be deprecated/removed from library

Today, the three possible sections (header + items + buttons) are manually positioned in code, which leads to a lot of additional code in the action sheet. Sheeeeeeeeet should use a stack view instead.

In order to fix the flickering issue that did occur when the app had a popover sheet presented when it was awaken from the background, I added a notification check that hid the sheet when the app was sent to the background. Since the flicker bug has been solved, this is no longer needed.

https://github.com/danielsaidi/Sheeeeeeeeet/blob/dc5637336911e95666ea0d8d30d645f161fda0df/SheeeeeeeeetExample/ViewController/ViewController%2BAlerts.swift

Your project usesUIAlertController but your action sheet is not based on this control. You should mention in readme why you did that or remove that code if it is extra

How can i change the appearance of individual items?
I tried this with no success

let a = ActionSheetItem(title: "foo", value: "1", image: nil )
a.appearance.textColor = .brown

Today, the select item type has no built-in selection logic, which means that you have to intercept that a select item is selected, then handle stuff like:

• Single or multi-select items should have .none as default tap behavior
• Single select items should auto-deselect all other items
• Single select items should only auto-deselect all other items within the same section

Hi Daniel,

I have notice that ActionSheetCancelButton button is visible in iPad popover.

Generally cancel button should not be in popover.

Quick Solution:
Before adding ActionSheetCancelButton item We can check if device is iPad or not.

But It would be great if this can be handle in Great Sheeeeeeeeet lib.

Thanks.

Sometimes, the table view controller is insufficient or too cumbersome to style (look at the horizontal collection example). Perhaps Sheeeeeeeeet should support custom view controllers?

I received this e-mail:

Good afternoon!

I have a question about your Sheeeeeeeeet Cocoapod. If I create a custom view with things such as a UITextField, DatePicker, etc, how would I go about accessing these values when I click OK? Here is some code to show what I was attempting to do:

let title = ActionSheetTitle(title: "App Info")
let customType = CustomViewCell.self
let item1 = ActionSheetCustomItem(cellType: customType) { cell in
let formatter = DateFormatter()
formatter.dateFormat = "MM/dd/yyyy"
            
       //set to current date
cell.updatedLabel.text = formatter.string(from: Date())
}
       
let button = ActionSheetOkButton(title: "Save")
return ActionSheet(items: [title, item1, button]) { sheet, item in
   
if item is ActionSheetOkButton {
             print("Save buttons has the value `true`")
              //access the values in item1 and do something with the data
       }
}

Thoughts on what I am missing?

Improve how action sheets calculate the available item height.

Can we create an action handler whenever a link is selected without removing the action sheet that was use. I want to present an alert view when I want the user to be able to come back to the same action sheet when they are finish with the alert.

Hi Daniel,
your library looks very great (it's really a nice job!!) and I'm considering to use it in my app.
I need to show until 8 options in actionsheet, so, to try, I modified foodOptions() function in SheeeeeeeeetExample like this

func foodOptions() -> [FoodOption] {
    return [.fast, .light, .homeMade, .fancy, .none, .fast, .light, .none]
}

and this is how action sheet appear on iPhone 7 simulator in landscape mode

I think in this case the action sheet should be able to scroll so that any option can be available (like Dropbox iOS app or Google Drive iOS app, for example).

Thanks,
Giorgio

Is there any way to change the background color of the UITableView?

The current action sheet presenter setup, where the ActionSheetDefaultPresenter class has an embedded presenter for iPad, is just horrible.

Instead, the action sheet should resolve the correct default presenter depending on the current device, and let the user set a custom presenter whenever needed.

ActionSheetCustomItem is currently untested. We should add tests for it.

If an action sheet has so many items that the table view becomes scrollable, the rounded corners are ruined when the scroll bounces.

I would like to run some code when the sheet dismisses because a user clicked outside of the sheets bounds. How would I accomplish this?

The collection item doesn't work when Sheeeeeeeeet is installed with CocoaPods. The xib isn't included in the spec, which cause the app to crash.

After adding scroll and extended notch handling to Sheeeeeeeeet, the peek now looks strange.

Today, an action sheet is correctly positioned in relation to a possible notch, which means that if you present a sheet in landscape, it uses the safe area insets. However, if you present the sheet in portrait then flip to landscape, it no longer uses the safe area insets, which causes it to expand beyond the notch.

I have tried, but I am just not nailing it. If anyone feels like helping out, I'd love some help with this.

I'd like this lib to have a nice logo like https://github.com/teodorpatras/EasyTipView - but the only thing I've come up with is a gray base with white boxes on top of it...really boring.

Specifically background color of all items. This would be a great addition to the appearance model especially with rise of dark themes.

Today, an action sheet always displays its header view, if one is set. However, on since iPhone landscape height is really limited, maybe there should be an option to hide the header view if the sheet is presented in landscape.

Hi!
Great library, I like it a lot.

However, It lacks the ability to switch between popover and action sheet modes when I change split-view mode on iPad.
Also, it presents itself on 2/3 split screen like it is an iPhone, while standard iOS ActionSheet still presents as a popover.

Please, take a look at this video: https://youtu.be/sS_jcHx8R-I

I tried to fix it myself but found that it requires some API change.

Hi Daniel,

Thanks for the great library.

I need help your help adding Select/unselect All in Multi-select sheet.

I want to select all other ActionSheetItem items when user select "All".

Can you help me to achieve this feature?

when device rotate in two orientation: landscape and portrait, sheet position place wrong postion

actionSheet.present(in: self, from: self.view) where self is a UITabBarController subclass, the sheet gets hidden below the tab bar.

Any thoughts on this?

At the moment I'm setting presenter property of the sheet to a new instance of ActionSheetDefaultPresenter and I pass nil as iPadPresenter. It works as I expected and it shows the mobile sheet on iPad.

However IMO the width is too much on iPad and I would like to make it half as wide.
I tried to create to create a custom presenter but failed to successfully change the frame width.

Please help.

Currently there is print in deinit which prints e.g. ActionSheet deinit. Granted, this print is not frequent and does not have any effect. But it does not feel clean. It would be nice to have some kind of debug printing level setting which disables this print by default and makes enabling it possible when needed.

Mainly turning off and changing color

At the moment one workaround for removing is:

let noSeparator = UIEdgeInsets(top: 0, left: 0, bottom: 0, right: UIScreen.main.bounds.width)
cell.separatorInset = noSeparator

Good: Can be done per cell
Bad: Has to be done for each cell if need to remove all

Hadn't found a way to change color without traversing view hierarchy

Hi Daniel,
I'm running into some trouble using your library on iPad. First, I see an annoying flickering when I put app in background with a Sheeeeeeeeet opened menu and take it in foreground again . To reproduce it

1. Run Demo
2. Open a menu (tap on standard row, for example)
3. Put app in background
4. Take it in foreground again

Second, in the demo app, when I open Standard menu and I tap a menu item no alert appears. In the console I see

SheeeeeeeeetExample[8754:168099] Warning: Attempt to present <UIAlertController: 0x7fdabd04f400> on <SheeeeeeeeetExample.ViewController: 0x7fdabbc06b10> which is already presenting (null)

Thanks,
Giorgio

The example app presents action sheets from the tapped cells. However, this means that on iPad, the popover will not use the available screen height, since it will be displayed above or below the cell.

Instead, present the action sheet from the cell's text label instead. This will make the action sheet float above the cell, making use of the entire iPad screen.