danielme85 / laravel-log-to-db Goto Github PK

how to get the URL on which issue occurred

Package have internal migration included.

It is hard registered inside the Serivce Provider and have own timestamp: 2018_08_11_003343_create_log_table
This leads to behavior that breaks normal flow of artisan migrate command in case the log table migration already exists with modified structure or should be created by migration leaded after that.
For example of modification: if the table needs to be separated to some kind of partitions, but it required to be exists before some previous migrations by the current migration's timestamp.

Current behavior force to do the manual per-file migration to avoid this problem.

I see several ways to fix this behavior:

1. Simplest solution: wrap migration by if (Schema::hasTable(...) { ... }. That is easiest but not the better way, 'cause it hides the migration from a dev and imposes some restrictions.

2. Better solution:

• 2.1. Remove the registration of the migration from the Service Provider

• 2.2. Add another one directive like directive with config to publishes a copy of the migration to common migrations directory on the normal laravel structire to allow modify it by dev's needs.

• 2.3. Rename migration to give it inert timestamp 0000_00_00_000000_create_log_table like it doing some of built-in migration of the framework. This kind of name of migrations should make it started 1st and when you publish it, it will appear at the beginning of the migrations list, that allow devs to catch sight of the migration and rename it giving timestamp they need or leave it as is.

Good day and great package. I've been using this package for a while now and it's been fabulous.

I ran into a bug and can't seem to figure out what is wrong. I am trying to log validation errors to the database. I have an ErrLog class to handle that.

public function report() { ErrLog::logValidationErrors($this->validator, $this->validation_class); }

And in ErrLog I have this

static function logValidationErrors(Validator $validator, FormRequest $validation_class) { if (DB::transactionLevel() > 0) { Db::rollBack(); } Log::error('hello', ['id' => 1]); // Log::error(get_class($validation_class) . ' validation failed.', ['data' => $validator->getData(), 'errors' => $validator->errors()->all(), get_class($validation_class) . ' validation failed.', 'context' => '']); }
The bug is this: As long as I have an array in the context parameter I get an Array to String conversion error.

If I remove the context entirely, it works, but if I supply any other parameter to context, the exception triggers a required array for parameter 2 error.

My composer file has and I have run composer update a couple of times over the past 2 days.

"danielme85/laravel-log-to-db": "^2.3", "laravel/framework": "^7.0", "laravel/tinker": "^2.0", "laravel/ui": "^2.0",

What could be wrong?

The error information is

`
danielme85\LaravelLogToDB\Models\DBLogException
Array to string conversion

vendor/danielme85/laravel-log-to-db/src/LogToDbCustomLoggingHandler.php:73

protected function write(array $record): void

{

if (!empty($record)) {

  if (

    !empty($record['context']['exception']) &&

    get_class($record['context']['exception']) === DBLogException::class

  ) {

    //Do nothing if empty log record or an error Exception from itself.

  } else {

    try {

      $log = new LogToDB($this->config);

      $log->newFromMonolog($record);

    } catch (DBLogException $e) {

      //do nothing if exception of self

    } catch (\Exception $e) {

      //convert any runtime Exception while logging to a special class so we can avoid our own

      //exceptions for 99% less infinite loops!

      throw new DBLogException($e->getMessage()); // This is line 73

    }

  }

}

`

Here is a link to the flare error if necessary.

https://flareapp.io/share/J7oDNG58

Thanks again for a wonderful package

This package is no longer compatible with Laravel 10.x, which is using Monolog 3.x, causing errors like this:

Declaration of danielme85\LaravelLogToDB\LogToDbCustomLoggingHandler::write(array $record): void must be compatible with Monolog\Handler\AbstractProcessingHandler::write(Monolog\LogRecord $record): void

The version constraint "illuminate/support": ">=5.6" is suggesting that it is actually compatible, which allows installing this package with Laravel 10.x.

Laravel Log to DB: v3.0.1
Laravel Octane: v0.2.0 (using swoole)
Laravel Framework: v8.37.0

Error:

exception: "danielme85\\LaravelLogToDB\\Models\\DBLogException"
file: "/var/www/html/vendor/danielme85/laravel-log-to-db/src/LogToDbCustomLoggingHandler.php"
line: 70
message: "Target class [config] does not exist."
trace: [{file: "/var/www/html/vendor/monolog/monolog/src/Monolog/Handler/AbstractProcessingHandler.php",…},…]
0: {file: "/var/www/html/vendor/monolog/monolog/src/Monolog/Handler/AbstractProcessingHandler.php",…}
1: {file: "/var/www/html/vendor/monolog/monolog/src/Monolog/Logger.php", line: 317, function: "handle",…}
2: {file: "/var/www/html/vendor/monolog/monolog/src/Monolog/Logger.php", line: 539, function: "addRecord",…}
3: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Log/Logger.php", line: 174,…}
4: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Log/Logger.php", line: 87,…}
5: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Log/LogManager.php", line: 555,…}
6: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Exceptions/Handler.php",…}
7: {file: "/var/www/html/app/Exceptions/Handler.php", line: 39, function: "report",…}
8: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php", line: 49,…}
9: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 172,…}
10: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php",…}
11: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php",…}
12: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
13: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php",…}
14: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
15: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 103,…}
16: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php", line: 697,…}
17: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php", line: 672,…}
18: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php", line: 636,…}
19: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php", line: 625,…}
20: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php", line: 166,…}
21: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 128,…}
22: {file: "/var/www/html/vendor/barryvdh/laravel-debugbar/src/Middleware/InjectDebugbar.php", line: 60,…}
23: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
24: {,…}
25: {,…}
26: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
27: {,…}
28: {,…}
29: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
30: {,…}
31: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
32: {,…}
33: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
34: {file: "/var/www/html/vendor/fideloper/proxy/src/TrustProxies.php", line: 57,…}
35: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 167,…}
36: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php", line: 103,…}
37: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php", line: 141,…}
38: {file: "/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php", line: 110,…}
39: {file: "/var/www/html/vendor/laravel/octane/src/ApplicationGateway.php", line: 36, function: "handle",…}
40: {file: "/var/www/html/vendor/laravel/octane/src/Worker.php", line: 92, function: "handle",…}
41: {file: "/var/www/html/vendor/laravel/octane/bin/swoole-server", line: 119, function: "handle",…}
42: {function: "{closure}"}
43: {file: "/var/www/html/vendor/laravel/octane/bin/swoole-server", line: 169, function: "start",…}

My guess is that it has to do something with how config file is loaded - it is different in Octane https://github.com/laravel/octane#dependency-injection--octane

There are two methods with typo in them: 'removeOldestIfMoreThen' and 'removeOlderThen'. 'Then' should be replaced by 'Than' to be correct English sentence. Or, at least, this issue should stay here to inform others about this potential issue in otherwise great package.

Laravel 7 uses Throwable instead of Exception: https://laravel.com/docs/7.x/upgrade#symfony-5-related-upgrades

The column context in the table log is always empty because the method parseIfException do not expect Throwable.

Hello,

I am getting this particular message when putting the log into the queue. I followed the installation guide to a T - am I missing something? Below is the stack trace. If i don't put it into the queue everything works.

Illuminate\Database\Eloquent\ModelNotFoundException: No query results for model [danielme85\LaravelLogToDB\Models\DBLog]. in /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php:452 Stack trace: #0 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/SerializesAndRestoresModelIdentifiers.php(85): Illuminate\Database\Eloquent\Builder->firstOrFail() #1 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/SerializesAndRestoresModelIdentifiers.php(55): danielme85\LaravelLogToDB\Jobs\SaveNewLogEvent->restoreModel(Object(Illuminate\Contracts\Database\ModelIdentifier)) #2 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/SerializesModels.php(45): danielme85\LaravelLogToDB\Jobs\SaveNewLogEvent->getRestoredPropertyValue(Object(Illuminate\Contracts\Database\ModelIdentifier)) #3 [internal function]: danielme85\LaravelLogToDB\Jobs\SaveNewLogEvent->__wakeup() #4 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(42): unserialize('O:46:"danielme8...') #5 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/Jobs/Job.php(83): Illuminate\Queue\CallQueuedHandler->call(Object(Illuminate\Queue\Jobs\RedisJob), Array) #6 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(327): Illuminate\Queue\Jobs\Job->fire() #7 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(277): Illuminate\Queue\Worker->process('redis', Object(Illuminate\Queue\Jobs\RedisJob), Object(Illuminate\Queue\WorkerOptions)) #8 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(118): Illuminate\Queue\Worker->runJob(Object(Illuminate\Queue\Jobs\RedisJob), 'redis', Object(Illuminate\Queue\WorkerOptions)) #9 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(102): Illuminate\Queue\Worker->daemon('redis', 'default', Object(Illuminate\Queue\WorkerOptions)) #10 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(86): Illuminate\Queue\Console\WorkCommand->runWorker('redis', 'default') #11 [internal function]: Illuminate\Queue\Console\WorkCommand->handle() #12 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(29): call_user_func_array(Array, Array) #13 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(87): Illuminate\Container\BoundMethod::Illuminate\Container\{closure}() #14 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(31): Illuminate\Container\BoundMethod::callBoundMethod(Object(Illuminate\Foundation\Application), Array, Object(Closure)) #15 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Container/Container.php(572): Illuminate\Container\BoundMethod::call(Object(Illuminate\Foundation\Application), Array, Array, NULL) #16 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Console/Command.php(183): Illuminate\Container\Container->call(Array) #17 /home/vagrant/b2b/vendor/symfony/console/Command/Command.php(255): Illuminate\Console\Command->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Illuminate\Console\OutputStyle)) #18 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Console/Command.php(170): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Illuminate\Console\OutputStyle)) #19 /home/vagrant/b2b/vendor/symfony/console/Application.php(901): Illuminate\Console\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #20 /home/vagrant/b2b/vendor/symfony/console/Application.php(262): Symfony\Component\Console\Application->doRunCommand(Object(Illuminate\Queue\Console\WorkCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #21 /home/vagrant/b2b/vendor/symfony/console/Application.php(145): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #22 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Console/Application.php(89): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #23 /home/vagrant/b2b/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(122): Illuminate\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #24 /home/vagrant/b2b/artisan(37): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #25 {main}

In case database failure, once the exception rises inside the job, on attempt to write the log entity to the database, it generates a new log write event, that is pushing to the log queue and attempt to write a new log entity to the database again, that will cause another exception at the same place, and so on.

It immediately cause the water flow cascade effect on the queue, and it's overflow and fail because OOM.

Hello,

First off, thank you for this awesome package - it is saving me a lot of work. I am having to customize it to our needs, but it works really well to begin with.

I have stumbled across a problem, and this is tested on a fresh install to assure that it is not my mistake.

The problem is that when you turn on the 'stack' channel for logging, the IntrospectionProcessor __invoke never gets hit, causing all of the logs to exclude the IntrospectionProcessor (file, class, etc..).

It seems that it tries to hit the local channels, before the database channel. After that, it uses the formatting for the local channel instead of the formatting for the DB logger. Not sure if this could be overridden - if that's the case.

Am I missing something here?

In your example of config logging.channels.database you are missing commas on entries: queue, queue_name, queue_connection.

'database' => [
    'driver' => 'custom',
    'via' => danielme85\LaravelLogToDB\LogToDbHandler::class,
    'level' => env('APP_LOG_LEVEL', 'debug'),
    'name' => 'My DB Log',
    'connection' => 'default',
    'collection' => 'log',
    'detailed' => true,
    'queue' => false
    'queue_name' => ''
    'queue_connection' => ''
]

Lumen v9.1.2
PHP v8.1

Hi there, I am getting the following error when trying to register the service provider in app.php
So after adding: $app->register(\danielme85\LaravelLogToDB\ServiceProvider::class); to app.php here is the eror that I am getting:

www-data@c2bfa1bae2d0:~/html$ vendor/bin/phpunit 
PHPUnit 9.5.25 #StandWithUkraine

.PHP Fatal error:  Cannot redeclare danielme85\LaravelLogToDB\config_path() (previously declared in /app/vendor/danielme85/laravel-log-to-db/src/ServiceProvider.php:31) in /app/vendor/danielme85/laravel-log-to-db/src/ServiceProvider.php on line 31
PHP Stack trace:
PHP   1. {main}() /app/vendor/bin/phpunit:0
PHP   2. include() /app/vendor/bin/phpunit:123
PHP   3. PHPUnit\TextUI\Command::main($exit = *uninitialized*) /app/vendor/phpunit/phpunit/phpunit:98
PHP   4. PHPUnit\TextUI\Command->run($argv = [0 => 'vendor/bin/phpunit'], $exit = TRUE) /app/vendor/phpunit/phpunit/src/TextUI/Command.php:97

LOG:
[2019-10-11 09:25:44] debug.DEBUG: This is an test DEBUG log event [2019-10-11 09:25:45] debug.ERROR: Argument 1 passed to danielme85\LaravelLogToDB\Models\DBLog::setDatetimeAttribute() must be an instance of Monolog\DateTimeImmutable, instance of DateTime given, called in \vendor\laravel\framework\src\Illuminate\Database\Eloquent\Concerns\HasAttributes.php on line 615 {"userId":9,"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Argument 1 passed to danielme85\\LaravelLogToDB\\Models\\DBLog::setDatetimeAttribute() must be an instance of Monolog\\DateTimeImmutable, instance of DateTime given, called in \\vendor\\laravel\\framework\\src\\Illuminate\\Database\\Eloquent\\Concerns\\HasAttributes.php on line 615 at \\vendor\\danielme85\\laravel-log-to-db\\src\\Models\\LogToDbCreateObject.php:115)

I just followed the main tutorial and did this:

Log::debug("This is an test DEBUG log event");

All other channels work fine but database one makes the aplication throw 500 Error

Hello,

Thank you for the package. I'm not sure, where to ask, so i will try to do it here?

I want to log data to database only on specific channels. Is it possible?

I have tried:

\Log::channel('facebook')->debug('Debuging data:'.print_r($postData, true));

And my logging.php looks like this:

// Facebook 'facebook' => [ 'driver' => 'database', 'level' => 'debug', ],

But it doesn't work with database, it works only with default laravel logger. Probably i missed something?

Thank you.

In Laravel 5.8, to get a query-able model back from the ext you have to do:

        $logs = LogToDB::model(
            null,
            'mongodb',
            'log'
        )->newModelQuery();

Else even though where() does not throw an error, it does not seem to do anything either.

When using this log channel with queueing and the queue is unavailable (e.g. Redis is not running or the database is unavailable), I would expect that errors occuring at that moment will be logged to the emergency channel. However, I don't see those errors logged anywhere. Maybe it's a configuration thing, however - in that case it would be nice to add something about it in the documentation.

Exception log events does not seem to reach the logging job queue.

The observers or the closure event of the Log model are not fired.

Add a Console command that can prune/delete old log records based on number of records or datetime.

Hello. Log entry does not work if there are errors in the view. This leads to an error:

Serialization of 'Closure' is not allowed {"userId":1,"exception":"[object] (danielme85\LaravelLogToDB\Models\DBLogException(code: 0): Serialization of 'Closure' is not allowed at /home/.../danielme85/laravel-log-to-db/src/LogToDbCustomLoggingHandler.php:70)

it write to file, but not write to database

database log is system error, \Log::error("something") not work

Hello. Please tell me for what purpose intended field extra?
I have all the records contain only one text "{"file":"/home/vagrant/ay-tech/vendor/laravel/framework/src/Illuminate/Log/Logger.php","line":176,"class":"Illuminate\Log\Logger","function":"writeLog"}"
Maybe I'm doing something wrong?

I use Laravel v6

Functions: 'removeOlderThan' and 'removeOldestIfMoreThan' does not work as intended when using mongodb. Currently functionality relies on 'id' being present in the DB, since it don't use migration to create mongodb collection it's '_id' per default.

Shouldn't getContextAttribute($value) and getExtraAttribute($value) be something like the following?

public function getContextAttribute()
{
     return $this->jsonDecodeIfNotEmpty($this->attributes['context']);
}

public function getExtraAttribute()
{
        return $this->jsonDecodeIfNotEmpty($this->attributes['extra']);
}

I'm gonna try to add some better lumen support, this addon has never been properly tested with Lumen and would probably need some tweaks to work and make installation easier.

• Test practical use in Lumen.
• Make tweaks as needed.
• Add Lumen install instructions to readme.

Should make it easier and avoid confusion as: #23

Hi Daniel, first of all, great work with this package - thanks for that!
Is there a chance to get a release to packagist with the changes you applied a couple of weeks ago to support Laravel 11? By now, the package prevents updating to the latest and greatest. That would be awesome! 🙂

Hello @danielme85

I observed a bug. In my logging configuration, I set the collection instance to be something different from the default log. However when I try to prune using the log:delete command, it keeps failing with an error.

   Illuminate\Database\QueryException 
  SQLSTATE[42S02]: Base table or view not found: 1146 Table 'test.log' doesn't exist (SQL: select count(*) as aggregate from `log`)

I tried to look in the source and noticed that in LogCleanerUpper.php, both calls to the LogToDb::model() method seem to be outdated.

The LogToDb model has a signature of
public static function model(string $channel = null, string $connection = 'default', string $collection = null), but both calls
are done this way LogToDB::model($connection, $collection).

This makes the collection perpetually null and therefore falls back to default.

Doing this fixes the error for me LogToDB::model(null, $connection, $collection) but this may not be what you'd prefer.

Kindly look into it and thanks for the great work.