daniellau88 / ped Goto Github PK

Hi, the user guide link in the jar file is currently not updated yet (it is still using the old link).

According to the UG, add module is suppose to flag up a warning if it is added without prerequisites.

However, if addm p/1 s/1 m/CS2030S was run, the warning does not show up.

The following command results in an error.

The current JAR link is linking the the docs folder. Would be good if it is linked to the JAR release instead.

If the json file was modified, it is possible to add 2 different master plans. Would be good to add some validations while importing the json file.

The field given is description. Would be good if the error message specifies Description instead of Addresses.

In the following 2 use cases, the SEM_NUMBER refers to different things

Case 1:

The SEM_NUMBER here refers to the actual sem number, e.g. if I add semester 5 to plan 1, it will be reflected as semester 5 in plan 1

Case 2:

The SEM_NUMBER in addm on the other hand refers to the index of the sem number, e.g. if I add module to semester 5, it will add to the 5th semester in the plan rather than semester 5.

Case 3:

The SEM_NUMBER in deletem refers to the actual sem number, e.g. if I delete module from semester 5, it will delete the module in semester 5 of plan 1

Do specify which is which case in the UG.

Hi, when I keyed in the following command, the program did not respond.

Edit: addm will not return any error message too

The format for deleting should be deletep p/PLAN NUMBER in the user guide

Not sure if this was intended, but finding module by module code should preferably be case insensitive matching.

Addon: the equals method for module compares module code case insensitive (I can't add 2 modules of the same code but of different case), so would be good if this is consistent as well

Incorrect error message when delete module command is called.

The aspect ratio of the table is a bit out of place and the words cannot be seen in full.

Not sure why the command is not working, might not be a bug so let me know :).

The command called was addm m/cs1231 p/1 s/3.

The semester that it adds to is the 3rd semester (which is semester 5 if you refer to the json file). Hence, it should be added to Plan 1 Semester: 5 instead.

Not sure if this was intended.

When the plan number is invalid, the isMaster for all the plan will be set to false (even though the plan number can't be found).

Not sure if it is intended behavior, but would be better if the state of all plans do not change.

^ In the cases above, the 2nd plan was unset as master plan

The current semester is set to semester 3, but the history only shows semester 2 and not semester 1 and 0 (JSON file as below).

{
  "plans" : [ {
    "description" : "Initial Plan",
    "isMasterPlan" : true,
    "tagged" : [ "sample" ],
    "semesters" : [ {
      "semNumber" : 2,
      "modules" : [ {
        "moduleTitle" : "Discrete Structures",
        "moduleCode" : "CS1231",
        "moduleCredits" : 4,
        "descriptions" : null,
        "isDone" : false,
        "grade" : "-",
        "prerequisites" : [ ],
        "preclusions" : [ ]
      } ]
    }, {
      "semNumber" : 3,
      "modules" : [ {
        "moduleTitle" : "Discrete Structures",
        "moduleCode" : "CS1231",
        "moduleCredits" : 4,
        "descriptions" : null,
        "isDone" : false,
        "grade" : "-",
        "prerequisites" : [ ],
        "preclusions" : [ ]
      } ]
    }, {
      "semNumber" : 0,
      "modules" : [ {
        "moduleTitle" : "Discrete Structures",
        "moduleCode" : "CS1231",
        "moduleCredits" : 4,
        "descriptions" : null,
        "isDone" : false,
        "grade" : "-",
        "prerequisites" : [ ],
        "preclusions" : [ ]
      } ]
    }, {
      "semNumber" : 1,
      "modules" : [ {
        "moduleTitle" : "Research Methodology",
        "moduleCode" : "CS2309",
        "moduleCredits" : 4,
        "descriptions" : null,
        "isDone" : false,
        "grade" : "-",
        "prerequisites" : [ ],
        "preclusions" : [ ]
      } ]
    } ]
  }, {
    "description" : "Plan B",
    "isMasterPlan" : false,
    "tagged" : [ ],
    "semesters" : [ ]
  }, {
    "description" : "plan C",
    "isMasterPlan" : false,
    "tagged" : [ "LASTRESORT" ],
    "semesters" : [ ]
  } ],
  "currentSemesterNumber" : 3
}

Is semester 0 suppose to be valid in the database?

1. It is possible to add semester 0 into a plan
   

2. However, it is not possible to set current semester to semester 0 (not sure if it is intended)
   

3. It is possible to add a module to semester 0 (because it uses index based)
   

4. It is not possible to delete a module from semester 0
   

Edit: it is possible to add a -1 semester too

1. The clear command's header seems to be a bit out of place in the UG.

1. The photo is not found in the UG. Not sure if you have included it.

1. The example output seems like out of line.

The format for valid current command usage is not specified.