danieleteti / dsfc Goto Github PK

Hi Daniele, here is the code. My email is francis at cicar dot com.

Thank you very much.

Francis

Hello there, I think something is wrong in your library with the cipher 
filters

In the server side is impossible to set a crypt_key.

And also I don't see anywhere how to set the crypt_key in the client side.

Regards

What steps will reproduce the problem?
1. add the filter in he server to DSHTPservice.Filters in the IDE 
2. Run the server 
3. Error appears imediatly
Error reading TTransportFilterItem.FilterId: Illegal argument

What is the expected output? What do you see instead?
I expected the server to run not to give an error message

What version of the product are you using? On what operating system?
Delphi XE windows 7 32bits

Please provide any additional information below.
If need I can provide you with an demo project.

What is the expected output? What do you see instead?
Integer overflow

What version of the product are you using? On what operating system?
Delphi 2010 win 2003 32bit

Please provide any additional information below.

procedure TCipher_RC6.DoInit(const Key; Size: Integer);
var
  K: array[0..63] of LongWord;
  D: PLongArray;
  I,J,L,A,B,Z,T: LongWord;
begin
  if FRounds = 0 then FRounds := 20 else
    if FRounds < 16 then FRounds := 16 else
      if FRounds > 24 then FRounds := 24;
  D := FUser;
  FillChar(K, SizeOf(K), 0);
  Move(Key, K, Size);
  L := Size shr 2;
  if Size and 3 <> 0 then Inc(L);
  if L <= 0 then L := 1;
  J := $B7E15163;
  for I := 0 to (FRounds + 2) * 2 do
  begin
    D[I] := J;
    Inc(J, $9E3779B9);
  end;

$B7E15163 + $9E3779B9 > LongWord 

Hello,

The key property doesn't is saved when you close a server project and reopen 
it. Is easy to test.

Regards and thank you very much.