danielandreasen / astro_scripts Goto Github PK

Here is a sample that might help read UVES data

def read_uves(filename):
    hdulist = pyfits.open(filename)
    header = hdulist[0].header #read header
    spec = hdulist['SPECTRUM'].data
    wave = spec['WAVE'][0]
    flux = spec['FLUX_REDUCED'][0]
    return wave, flux

It could be easier for quick excecution if plot_fits.py detected the instrument type in the header instead of the drop down list.

Having it default to ARES I have missed changing it to CRIRES in a hurry and therefore get the error.

Traceback (most recent call last):
  File "..Repos/astro_scripts/plot_fits.py", line 566, in <module>
    main(fname, **opts)
  File "..Repos/astro_scripts/plot_fits.py", line 334, in main
    w = get_wavelength(hdr)
UnboundLocalError: local variable 'hdr' referenced before assignment

The CRIRES header has a value INSTRUMENT= 'CRIRES' (I assume ARES would be similar), which would be simple enough to check for example something like ...

if hdr["INSTRUMENT"] is "CRIRES ":
    do this    
elif hdr["INSTRUMENT"] is "ARES":
    do that

Also a bug:
The help text gets hidden behind the Gooey boxes for model and lines. Also a spelling mistake in model help.

It could be nice to save the output in a 1D fits format corrected for RV. The latter not super important.

If either the model or sun is shifted in RV, so should the lines given with the -l flag.

Instead of having the data here, take advantage of it being at my home page: http://www.astro.up.pt/~dandreasen/README

Need to put the tellurics there as well.

1. If the data does exist already, don't dowload it.
2. If the data does not exist, download it and put it in a place where it can always be looked for.

Currently it is hopeless to use plot_fits from within python. Only a CLI is really possible. Fix this, for better integration.

When calculating the CCF, then check if given rvmin and rvmax is out of range. If they are, set them at the limit.

It would be really helpful to see the CCF when it is calculated.

This seems to be easy to write in Python, so do that.

Since some of the scripts is working nice, maybe a web page with tutourials and examples would be nice, so other people start using it.