The pl-projects from dandigit

dandigit / pl-projects Goto Github PK

View Code? Open in Web Editor NEW

Following along with Bob Nystrom's excellent book, Crafting Interpreters.

License: MIT License

Java 66.22% Shell 0.06% CMake 0.16% C 30.07% C++ 3.49%

pl-projects's People

Contributors

Stargazers

Watchers

pl-projects's Issues

One line comment is broken in jlox

In case the script starts with one line comment the interpreter breaks

It works if it's not the first line in the script

The bug also happens in the REPL mode and produce the same message

[clox] Common constant instructions all increment the line number.

This is a weird one.
OP_TRUE, OP_FALSE and OP_NIL all increment the line number of the instruction after it.

Here's some sample output:

lox > nil
== code ==
0000    1 OP_NIL
0001    2 OP_RETURN
          
0000    1 OP_NIL
          [ nil ]
0001    2 OP_RETURN
nil

After nil, the line number is incremented.

lox > true == true
== code ==
0000    1 OP_TRUE
0001     | OP_TRUE
0002     | OP_EQUAL
0003    2 OP_RETURN
          
0000    1 OP_TRUE
          [ true ]
0001     | OP_TRUE
          [ true ][ true ]
0002     | OP_EQUAL
          [ true ]
0003    2 OP_RETURN
true

This one is really strange. OP_EQUAL and the other OP_TRUE are on the same line but OP_RETURN is on the other line for some reason.

Recommend Projects