Code Monkey home page Code Monkey logo

Comments (5)

DandelionSprout avatar DandelionSprout commented on June 12, 2024 2

Okay, so it turns out that there's several dozen similar !#if tags in the first of those files, making me wonder how on earth I even managed to do such a mistake in my conversion scripts in the first place.

This gives me a faint clue on how to fix this, but the implementation of that fix(es) won't be a stroll in the park, sadly.

from adfilt.

iam-py-test avatar iam-py-test commented on June 12, 2024 1

Anyways they're not valid for hosts, domains, and most likely other formats.

!#if is valid syntax in uBlock Origin and AdGuard, and is treated as a comment in AdBlock/ABP. PiHole should treat them as comments, though it may not, as it handles "adblock" syntax filterlists different from every other mainstream content blocker.
That said, they are not valid in HOSTs/domains style files.
Thanks

from adfilt.

ThinkChaos avatar ThinkChaos commented on June 12, 2024 1

Thanks!

from adfilt.

DandelionSprout avatar DandelionSprout commented on June 12, 2024

I've been on a run lately, where I've tried to ensure that most of my lists (except those that are included as opt-out or opt-in in adblockers, before anyone asks) would be forcibly non-working in uBO Minus or AdGuard MV3; and uBO have traditionally been able to handle both Hosts and raw domain files very easily.

So I admit I'm unsure how to handle this.

from adfilt.

ThinkChaos avatar ThinkChaos commented on June 12, 2024

I've been on a run lately, where I've tried to ensure that most of my lists (except those that are included as opt-out or opt-in in adblockers, before anyone asks) would be forcibly non-working in uBO Minus or AdGuard MV3; and uBO have traditionally been able to handle both Hosts and raw domain files very easily.

FWIW I'm using the list with blocky, and we've intentionally avoided implementing adblocking list directives since they're mostly irrelevant/unusable for DNS blockers.

I appreciate the goal of breaking extensions from bad actors, but I think having working hosts/domains is more important. Anyways I'd guess those extensions are less likely to use these list formats.

from adfilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.