damonge / cosmomad Goto Github PK

I’m trying to install your code (CosmoMad) on my laptop ( MacOS el capitan) and find some issues, the ./configure command seems to work properly , but then the make seems to fail giving :

/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-recursive
Making all in include
make[2]: Nothing to be done for all'. Making all in src make[2]: Nothing to be done for all’.

do you have a special installation pipeline for mac?

Hi, @damonge

I forgot why I am receiving the email from LSSTDESC/CCL#27 . But since I am not sleeping well - I'd read your code a bit and list a few concerns:

• demanding malloc for each object may choke up multithreading and fragments the memory. Most systems probably already use a malloc that doesn't suffer from these issues as bad. I am not sure. May worth checking this out a bit. I've been playing safe and always allowed objects on the stack. (_init vs _new)
• Some generated autotools files seem to have been committed to the repository, blow-ing up the size of the repo. We usually provide a bootstrap.sh that runs autoconf etc to generate these files.
  An example (which may be too old, but you get the idea):

https://github.com/gnome-globalmenu/gnome-globalmenu/blob/master/autogen.sh

• What about giving each method an Error * pointer argument for exception handling; then you can get rid of the verbosity and interaction with stdin / stdout; in this case IO are side effects and makes the library un-pure. It is an important design decision and may take a lot of effort, and requires disable the insane gsl error aborter at lib init.
  I understand the current design is because changing the default GSL's error handling implicitly during library initialization is not a very good idea. A good library shall not kill the client application upon an error anyways. Especially if you have python binding in-mind; but astropy.cosmology is pretty complete in its own regard.
• I highly recommend take a look at some of the GLib c API naming conventions. e.g. https://developer.gnome.org/gio/stable/GFile.html ; since your convention and that is quite similar.