daelmaak / ngx-gallery Goto Github PK

An empty 'items' array is setting the 'loop' flag to false forever, regardless if 'items' is updated afterwards and the 'loop' input set to true

see this.loop = this.items?.length > 1 ? this.loop : false;

when another gallery input, like thumbs is changed after items is already set, this line here clears all items, resulting in nothing to be shown.
https://github.com/daelmaak/ngx-gallery/blob/master/libs/gallery/src/lib/components/gallery/gallery.component.ts#L197

We ran into the issue, that items can be undefined here:

https://github.com/daelmaak/ngx-gallery/blob/master/libs/gallery/src/lib/components/gallery/gallery.component.ts#L195

i assume, it is due to center() not being called after inputs changed (https://github.com/daelmaak/ngx-gallery/blob/master/libs/gallery/src/lib/components/viewer/viewer.component.ts#L274)

my workaround currently is to call gallery.select(0) after we updated the items but this slides the images once :(

is there a way to remove the transition? i'd like to display 36 pictures of a car. with the drag of the pictures i could display them as a 360° image, but as long as there is any transition between the pictures, it's not gonna work. any idea?

currently there is no possibility to add aria labels to previous and next buttons in the gallery and the thumbs.
please provide a property for the aria object respectively.

Error:

TypeError: Cannot read properties of undefined (reading 'length')
    at ViewerComponent.getFringeCount (viewer.component.ts:284:59)

Hello can you please look into reviewing and accepting PR for initial RTL support
#35
thank you