dadaista / escrow Goto Github PK

At the moment there are a number of boolean flags instead of states. The correct state machine should be like

If approve is escalated to arbiter he can approve claim or do nothing. We need arbiter to reject a claim and send money to the opponent of claim

An escrow should emit events at every state change

Factory should create new escrow and lock funds in same transaction.

Now the CLAIMED state is only one whether it is supplier or customer. Lets have separate states PAY_CLAIMED and REFUND_CLAIMED and PAY_CLAIM_ACCEPTED and REFUND_CLAIM_ACCEPTED.

New State diagram is:

UNCLAIMED -- claim by supplier--> PAY_CLAIMED
UNCLAIMED -- claim by customer--> REFUND_CLAIMED
PAY_CLAIMED -- reject --> ESCALATED
REFUND_CLAIMED -- reject --> ESCALATED
PAY_CLAIMED -- accept by customer --> PAY_CLAIM_ACCEPTED
REFUND_CLAIMED -- accept by supplier --> REFUND_CLAIM_ACCEPTED
ESCALATED -- settle by arbiter --> SETTLED
PAY_CLAIM_ACCEPTED -- withdraw --> PAID
REFUND_CLAIM_ACCEPTED -- withdraw --> PAID
SETTLED -- withdraw --> PAID