Code Monkey home page Code Monkey logo

k3-translations's People

Contributors

daandelange avatar fk-3st avatar flokosiol avatar malvese avatar medienbaecker avatar pqml avatar sylvainjule avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

k3-translations's Issues

Kirby\Cms\Section::{closure}() Return value must be type string, null returned

Sorry i can't track this down i am just in middle of project. So this is very badly posted issue :(. Hopefully i get back to this in few weeks.

I've just installed your lovely plugin but suddenly its not possible to change status of pages from Draft to Unlisted/Listed

IWzQRNZ50X2KJZDU

It might be some plugin collision. Not sure yet.

Incompatibility with Uniform plugin

When Translations is enabled on my English/French sites, Uniform's "calc guard" field doesn't work properly anymore. It should display like this:
image
but instead displays like this:
image
The "plus" word no longer appears.

I don't know which plugin needs a fix, but since Uniform works fine when used alone I decided to file an issue here and ping @mzur for information.

Both plugins are updated to their latest version.

For what it's worth, I investigated a bit.
What I noticed is that in Uniform, in src/helpers.php line 38 the I18n::translate() function returns nothing when Translations plugin is present:
return Str::encode($a.' '.I18n::translate('uniform-calc-plus').' '.$b);

In Translations, in index.php line 212 and 223 (yes, this entry is duplicated) this kind of line seems to be the source of the issue:
'daandelange.translations.loading' => I18n::translate('loading', 'Loading', 'fr').'...',
If I delete both entries the calc guard works as expected.
I wonder why you did this instead of simply:
'daandelange.translations.loading' => 'Chargement…'

Status does not update after initial creation of translation

Hi there!

Thanks for the plugin. I have the issue that the status of a secondary language does not update in the moment when the new language version of the page is created, i.e. when I enter some translated text and save the page. Basically, the icon stays red and the button indicates that the page is still not translated. Only after a page reload does it correctly tell me that the page is translated. This is potentially confusing to editors creating these translations.

Thanks!

Kirby 4 compatibility ?

The plugin seems to work with kirby4 alpha-4 but i can't delete a translation :

Error in the delete pop-up :
The internal $model->contentFile() method has been deprecated. You can use $model->storage()->contentFile() instead, however please note that this method is also internal and may be removed in the future.

index.php line 118 : $filePath = $page->contentFile($languageCode, true);

with this change : $filePath = $page->storage()->contentFile($languageCode, true);
error in the same delete pop-up :
Invalid language: 1

Thanks !

config options have no effect

cannot disable revert or delete. Also, none of the other options have an effect.

  • version: 0.2.5-beta
  • kirby: 3.7.5.1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.