d8-x / d8x-trader-frontend-lite Goto Github PK

Can we combine all connected orders in 1 toast? Main, TP and SL?

macbook 13 inch:

Options:

1. apply the mobile order block for smaller laptops
2. globally shrink everything, "90%" zoom setting ?

• Ensure that after switching from Vault --> Trade --> Vault the initialy loaded values from Vault are directly shown. They should be stored in the corresponding Atoms.
• Check why initial loading of SDK values in Vault is so slow

• Dropdown that allows to select between base, usd and collateral currency
• use current base/usd price to determine the base amount if user specifies usd amount
• use current base/collateral price to determine the base amount if user specifies collateral currency amount

• Mobile & Desktop: On the top row fix the position of the quote currency, it jumps around when the price becomes single-digit. Also there might be a way to fix the digits.

• Mobile & Desktop: Rename connect wallet to connect to "connect"

• Mobile: Make sure the bg cant be moved so that the grey border appears to the right or left.

• Mobile: The bg should be turned 180 degrees like in figma, so that blue is everywhere, right now the bottom part is just grey

• Mobile: Add separator between Perpetual selector and start of price row like in figma

• Mobile: make collateral/perpetual selector in white boxes like in figma

• Mobile: check paddings, padding of white price boxes in mobile is for example not correct (should be padding: 12px 16px; but is 20px 24px). Check all other paddings please

• Mobile: check gap, gap between elements in figma is 16px, should also be the same here

• Mobile [Optional]: Should we put the buttons for stopp loss etc on two rows like in figma? I'm not sure, on my mobile the buttons on one row are just large enough to click.

• selector redesign on mobile (on one line, ideally the "dropdown" should work as per native option on iphone/android, native-select?)

• Total referral volume seems to not work for an agency addr, quantityCC is not 0, but the FE displays 0. I tested this with an agency address where the address is the agency and the referrer at the same time

Switching between open order tab and position tab triggers this:

• Round values under your referral and your discounts using the same logic as elsewhere in the FE (check: mapCurrencyToFractionDigits)

--> make a class

Provide Modal window with "Lorum ipsum" text and one link for reuse and modification.
This Modal window should be open for the first time page is entered and modal is closed after.
On Close action, it should not be shown for other time when page is open.

Texts should be centered by height.
Something wrong with paddings.

• order block redesign for mobile

Brave browser does not work right now see in discord

Convert form relative shares to absolute rebates (from 33% 33% 33% to 20% 20% 20% if the total rebate is 60%)

--> ask caspar

• Active buy button: 089981
• Active sell button: F23645

Investigate if we can introduce gasless token approvals with Permit2: https://blog.uniswap.org/permit2-and-universal-router

The error from canceling a tx is not captured by .catch(async (error) => { on line 268,

As a consequence the lock is never released and requestSentRef.current and requestSent remain true

Right now you can confirm an order collateralized in pragMatic, even if you have 0 pragMatic as collateral (see discord video)

--> we should a check that checks if the user has sufficient collateral in his wallet as an additional validity check

• Chart icon for mobile view should show/hide the chart.
• Chart view should be saved in case of refresh (localStorage variable).
• Chart should be shown always for not mobile views.

Input components in referral view should be aligned with input design in other components.

For this, ResponsiveInput shall probably be used which also aligns the mobile view to show proper + / - action buttons.

Sort by submittedTimestamp, newest order on top

Add it as top item into this block:

• price stats bar redesign as per figma

Think about this:

• trading with a code seems to not (immediately ?) impact https://referral.dev.quantena.tech/open-trader-rebate?addr=0x863AD9Ce46acF07fD9390147B619893461036194

• add loading icon
• make text green if check passed, else make it red

Research and decide on how to set up multi-language support.

Currently language is spread all across the code. To efficiently add multiple languages we need to centralize all language elements in one place (or one place per page).

Is i18n a solution? https://dev.to/franklin030601/building-a-multi-language-app-with-react-js-2och

• Add Info icons to all items in the "Your stats" block for Vault view. (VICTOR you can start with dummy text for now)

The info text needs to address points including:

• Do I still earn yield on my assets while they are in the process of withdrawal?
• What happens if my withdrawal is ready but I haven't withdrawn just yet? Do they still earn yield while they wait to be withdrawn?
• Does my withdrawal request expire after some time and money goes back into my deposit, or does it sit there ready to be withdrawn no matter how long I let it sit there? (weeks, months, years??)

Tx fails for cancel orders:

cancelOrder tx hash: 0x6bd2b9d55b6b216100c9e00921efc1b568448954164457dfeadee69afcc19424
https://mumbai.polygonscan.com/tx/0x6bd2b9d55b6b216100c9e00921efc1b568448954164457dfeadee69afcc19424

cancelOrder tx hash: 0xdc5ccc44cd1e47679bcca387b9fa3cd5abc325316de87291cc99670fed7de8fe
https://mumbai.polygonscan.com/tx/0xdc5ccc44cd1e47679bcca387b9fa3cd5abc325316de87291cc99670fed7de8fe

add collateral:
0x619e271068787eeedcf4055f09badb5639542c24b00901c51a9259088b623061

remove collateral:
https://mumbai.polygonscan.com/tx/0xc59c7b97bcadfc581a16fcb1c75f714170dd9e01b3ece17f438d40a0af5bd439

Error message "Fail with error 'invalid updt'"

Rework as per Figma:

https://www.figma.com/file/b4eyBlaymWGDnjoUcUDLHZ/D8X---New-Design---edit?type=design&node-id=16%3A279&mode=design&t=vgAbhu6KywccRpnv-1

Right now we simply increase/decrease by 1

As per Figma

Right now the left aligned colums are very close to right aligned colums (pos size and side). Is there a simple way to make the column distribution better while keeping the left and rightaligned logic?

• formatToCurrency needs to be updated. Currency cannot be hardcoded, this must be quote currency (it's not always USD), we can have ETH/BTC collateralized in MATIC

• the position of currency should be stable for a given number of digits: if you have XXX.XX USD, the "USD" is always at the same position independently of what number X is. if the number changes to XXXX.XX USD, "USD" moves once.

Button is not working

Looks like even with 8 codes no pagination happens