d4rken-org / reddit-android-appstore Goto Github PK

Details screen needs a viewpager like widget that takes bitmaps, can scroll and allows screenshots to be clicked to view them in higher resolutions.

Parse contact data:
https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/backend/BodyParser.java#L174

Add tests to confirm it works:
https://github.com/d4rken/reddit-android-appstore/blob/master/app/src/test/java/subreddit/android/appstore/backend/WikiRepositoryTest.java

We already have the secondary category headers (e.g. ## Action Games) just need to generate tags for those and add them.
https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/backend/BodyParser.java#L126

Add tests to confirm it works:
https://github.com/d4rken/reddit-android-appstore/blob/master/app/src/test/java/subreddit/android/appstore/backend/WikiRepositoryTest.java

Improve price column parsing. Try to get the actual price value if the entry has one:
https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/backend/BodyParser.java#L151

Add tests to confirm it works:
https://github.com/d4rken/reddit-android-appstore/blob/master/app/src/test/java/subreddit/android/appstore/backend/WikiRepositoryTest.java

Nexus 5 @ 6.0.1
Build from commit 47209cc

These should be wrapped in markdown, i.e.

[name](link)

 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from https://www.doubletwist.com/contact
 W/RAS:ContactColumnParser: No contacts parsed from http://contact.njsoftware.com
 W/RAS:ContactColumnParser: No contacts parsed from somnibyte.net
 W/RAS:ContactColumnParser: No contacts parsed from http://contact.njsoftware.com
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from github.com/stoyicker/boats-xkcd/issues
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from https://support.bulling.mobi/
 W/RAS:ContactColumnParser: No contacts parsed from https://support.bulling.mobi/
 W/RAS:ContactColumnParser: No contacts parsed from http://j4velin-systems.de/contact.php
 W/RAS:ContactColumnParser: No contacts parsed from https://plus.google.com/communities/113518882152366646905
 W/RAS:ContactColumnParser: No contacts parsed from http://contact.njsoftware.com
 W/RAS:ContactColumnParser: No contacts parsed from livgames.com
 W/RAS:ContactColumnParser: No contacts parsed from livgames.com

Note4 @ 5.0.1
Build from bef4620
Dialog accent color is wrong.

https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/screens/list/FilterListAdapter.java#L80

Count and display the tags count in the filter drawer.

Back button needs to be added to the details activity

Add a fastscroller to the list displaying apps

Design a icon for the app with:

• Complies with material design spec
• Well designed
• Appropriate colors

Display a changelog dialog informing the user on what is new when a new version of the app is started for the first time.

Wiki now has new categories, move all filters out of the filter menu and into the navigation drawer, behind two categories, Apps and Games

Should open a website, your email app or possibly your reddit app to contact the author.
Needs to deal with entries that are just plain text instructions (possibly show a popup dialog in that case?).
Might need a new class such as ContactType.

Also see #2

https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/screens/details/AppDetailsFragment.java#L100

Parse description data better, see if we can pull more information (possibly tags) from it:
https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/backend/BodyParser.java#L169

Add tests to confirm it works:
https://github.com/d4rken/reddit-android-appstore/blob/master/app/src/test/java/subreddit/android/appstore/backend/WikiRepositoryTest.java

Quick mock-up of an idea for implementing a tablet UI

Basically, have the apps as cards with the app name and logo, then have an inset horizontal divider for your filters.

https://www.reddit.com/r/Android/comments/525srg/beta_the_first_public_release_of_the_randroid_app/d7hkl8k

Could help clean the code up a bit

Parse format data better, generate more tags:
https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/backend/BodyParser.java#L158

Add tests to confirm it works:
https://github.com/d4rken/reddit-android-appstore/blob/master/app/src/test/java/subreddit/android/appstore/backend/WikiRepositoryTest.java

Instead, free and paid should cancel each other out.

^

The two categories begining with W are not displayed, parser is probably exiting a category early

Flagging option for users to report misleading apps and broken entries.

Idea:

1. Move the contact button to the toolbar, if there is more than one contact method, show a popup
2. Replace the download button with a FloatingActionButton, if there is more than one download method, show a popup. (Fancy alternative: have a collapsible FAB show multiple child items if there is more than one download method)

Thoughts

• App data from the wiki gives us a target from which to scrape the urls for icons and screenshots
• As it's a resource intensive operation we should only get the media for apps we are actually viewing
• Glide will trigger a load request for list items that are display or details pages being opened
• Glide needs the URLs obtained through scraping
• Glide can't to the scraping because the scraping returns multiple relevant values that may be needed in other requests (e.g. one icon load request, multiple screenshot load requests)
• UX may cause multiple requests for the the same media

Sequence

• Icon ImageView becomes visible
• Glide does something like load(new AppIconRequest(appInfo))
• Glide has to first resolve the AppInfo item a ScrapeResult
• Glide asks a TargetScraper for the data
• The TargetScraper scrapes the target ensures there is at most one request per item and caches the scrape result
• Glide uses the scraped urls to load the images and caches them

Responsibilities

• Glides caches the Bitmaps
• TargetScraper caches the ScrapeResults
• WikiRepository caches the AppInfos

Issues

• There is an unknown amount of screenshots to load
• We could give glide a viewpager target that can be filled with an arbitrary amount of screenshots instead of manually initiating a load request per known screenshot and adding it to a viewpager?

Needs to deal with entries that are just plain text instructions (possibly show a popup dialog in that case?).
Might need a new class such as DownloadType.
Parsing already tries to get a name and an URL from the name column:
https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/backend/BodyParser.java#L136

https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/screens/details/AppDetailsFragment.java#L100

Image loading is on its way! But some users may wish to conserve data and not load the images so we should implement a option to disable image loading.
Depends on #39 and #40

To test:

• Screen interaction (e.g. clicking a list entry opens that apps details page)
• Screen rotation
• Using the navigation drawer to move about

The tools of choice:

• Mockito
• Espresso

Style:

• Instrumentationt tests belong in src/androidTest/...
• Test classes should follow the package structure as the classes they want to test.
• Test classes should have the same name as their test target, just postfixed with "Test".
• Method names testMethodToTest for basic behavior and testMethodToTest_forSpecificCases

When the server is unavailable (like blocked in my country) the app will crash rather than displaying an error message.

To test:

• Presenter (e.g. lifecycle behavior and callbacks)
• Data sources (e.g. caching behavior)
• Parsers (e.g. correctly parsing and dealing with edge cases)

The tools of choice:

• Mockito
• Robolectric (if necessary)

Style:

• Unit tests belong in src/test/...
• Test classes should follow the package structure as the classes they want to test.
• Test classes should have the same name as their test target, just postfixed with "Test".
• Method names testMethodToTest for basic behavior and testMethodToTest_forSpecificCases

Use Reddit userless api over scraping

If there is a new release on github, the app should inform the user about it so they can download the update.

https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/screens/list/AppListFragment.java#L161

An about page that shows:

• App name
• App version
• A link to the repo
• Licenses of used libraries

https://github.com/d4rken/reddit-android-appstore/blob/36e4daaa4a1f9969917c3fc3833213d68c684bf4/app/src/main/java/subreddit/android/appstore/screens/list/AppListPresenter.java#L45

Sort the app items by ... name?

Same dialog from nightmode pops up.

App creates a icon in the app drawer called "Leaks". FC's on startup.

Explanation is welcome.

See:
https://github.com/d4rken/reddit-android-appstore/blob/master/app/src/main/java/subreddit/android/appstore/screens/list/AppListPresenter.java#L49

Scrape images from google play, if a google play link is available