d0lfyn / 20210303-polyphony Goto Github PK

I'm interested in experimenting with this polyphony project, but as the title describes: I get the following error when attempting to load and run the polyphony script according to the readme:

`"Thread death!  undefined method `note' for Polyphony::Settings:Module"`

/Users/ethan/repos/20210303-polyphony/settings.rb:20:in `<module:Settings>'
/Users/ethan/repos/20210303-polyphony/settings.rb:5:in `<module:Polyphony>'
/Users/ethan/repos/20210303-polyphony/settings.rb:1:in `<top (required)>'
/Users/ethan/repos/20210303-polyphony/polyphony.rb:21:in `load'
/Users/ethan/repos/20210303-polyphony/polyphony.rb:21:in `block in <top (required)>'
/Users/ethan/repos/20210303-polyphony/polyphony.rb:20:in `each'
/Users/ethan/repos/20210303-polyphony/polyphony.rb:20:in `<top (required)>'

This is with v0.4.1, using a Sonic Pi dev build based on v4.0-beta-4, Ruby 2.7.2.

Any ideas about how to fix it?

Hi! Awesome work. Looking forward to learn a lot from you :)

As a friendly suggestion I think you could use require_relative, modules and include instead of eval_file in your project.

Check out Petal extension for Sonic Pi (https://github.com/siaflab/petal). Petal has a really nice project structure and i personally learned a lot from it.

I used similar project structure in my project Ziffers (https://github.com/amiika/ziffers), but its more hacky and not very rubular.