d-ronin / autotown Goto Github PK

Two dumps my end failed to fetch, with 416 response from Google storage thing. Checked them in Cloud Console and noticed they both have the same filename/path, and it's 0 bytes...
http://dronin-autotown.appspot.com/at/crash/ahFzfmRyb25pbi1hdXRvdG93bnIWCxIJQ3Jhc2hEYXRhGICAgJDVyNMKDA
http://dronin-autotown.appspot.com/at/crash/ahFzfmRyb25pbi1hdXRvdG93bnIWCxIJQ3Jhc2hEYXRhGICAgJCxqboIDA

So... the filename is the sha1 sum of the dump contents, that makes sense then.
mike@tracer:~$ echo -n '' | openssl sha1
(stdin)= da39a3ee5e6b4b0d3255bfef95601890afd80709

da/39a3ee5e6b4b0d3255bfef95601890afd80709 is the filename. ;)

Should probably check the length of the dump is non-zero there and return 400.

The guy did manage to send a non-empty dump: http://dronin-autotown.appspot.com/at/crash/ahFzfmRyb25pbi1hdXRvdG93bnIWCxIJQ3Jhc2hEYXRhGICAgJD45egLDA

I have a pull request in for the dronin.org website that puts the autotune stats on the home page. Right now there's around 130 rows in the table which is fine but over time it will eventually get big enough to slow down the page load noticeably. Can you add server side paging to the stats?

@dustin, currently no way to get older crashes, can we do something like this (totally untested/written in github comment editor 😁)?

func handleRecentCrashes(w http.ResponseWriter, r *http.Request) {
	c := appengine.NewContext(r)
	start, err := strconv.Atoi(r.FormValue("start"))
	if err != nil || start < 0 {
		start = 0
	}
	q := datastore.NewQuery("CrashData").Order("-timestamp").Offset(start).Limit(50)
	res := []CrashData{}
	if err := fillKeyQuery(c, q, &res); err != nil {
		log.Errorf(c, "Error fetching crash results: %v", err)
		http.Error(w, err.Error(), 500)
		return
	}

	mustEncode(c, w, r, res)
}

The board UUID should be hidden to protect user privacy. Also, making the UUID public opens the door for abuse of the system by submitting data with the same UUID that will then be associated with another board, leading to a poor user experience.

http://dronin-autotown.appspot.com/at/tune/ahFzfmRyb25pbi1hdXRvdG93bnIYCxILVHVuZVJlc3VsdHMYgICAgMCInQoM