cwilso / audiocontext-monkeypatch Goto Github PK
View Code? Open in Web Editor NEWMonkeypatch to use proper AudioContext naming on prefixed/deprecated named systems.
audiocontext-monkeypatch's People
Contributors
Stargazers
Watchers
Forkers
ehsan srikumarks znakzorro dinhkhanh lucozhao hezzze bestander andrewmalone jeremyckahn sojourneer clafou jipodine jamiedust mcwebb kirbysayshi jonham ivanzich therewasaguy thestipplist darkdoon angeldude erl-j oclement pocketfullofstarz snhwang stephenroddy ankitwebvillee georgetheslayer fishbite debbielloyd alexchern0vaudiocontext-monkeypatch's Issues
iOS9 `AudioBufferSourceNode#start()` throws DOM Exception
The following code will throw on iOS 9:
http://requirebin.com/?gist=f20e6ed34715e99a6fe4
The important part is ~ line 25:
sample.start(undefined);Calling sample.start() does NOT throw in iOS9.
Why does this matter? Because by default the Monkey Patch will allow when to be undefined: https://github.com/cwilso/AudioContext-MonkeyPatch/blob/gh-pages/AudioContextMonkeyPatch.js#L100.
I wanted to write up a patch, but I haven't had time to check the spec for what is actually allowed to be undefined and what is not (there could be other discrepancies, including the other parameters of .start but my code only uses AudioBufferSourceNodes at the moment).
Merge master into gh-pages?
Hello Chris
Thanks for this library :-)
A while ago you merged Stuart Memo's nice patch that made the library work with Safari too, but apparently the gh-pages branch is the default for this project, and it's the first thing visitors see.
You might have your personal reasons (maybe using gh-pages for publishing) but I wonder if you could merge master into gh-pages so that people get the latest version by default.
Support for new `createStereoPanner` method
OfflineAudioContext() support
Would it be possible to add support for OfflineAudioContext()/webkitOfflineAudioContext()?
Found a typo: bufferSource.noteoff should be .noteOff
https://github.com/cwilso/AudioContext-MonkeyPatch/blob/gh-pages/AudioContextMonkeyPatch.js#L95
node.stop = node.noteoff;
to
node.stop = node.noteOff;
Thanks for a nice patch, Chris!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.