cwdoh / paper-fab-menu Goto Github PK

Bug found in paper-fab-menu.html
After one click, the icon is set properly, the bug can be fixed by adding
this.$.trigger.icon = this.icon; inside the ready: function().

Nice work with the menu!

Similar to googlearchive/core-overlay#56, the menu and tooltips appear "below" the core-overlay in iOS 8.
In this case though, layered is already specified and I can't actually get any paper-fab-menu-item on-tap handler to be invoked, so the overlay is actually above the menu in this case.

It would be nice if there was an option to use / not use overlay with menu.

a way to open FAB downward instead of upwards

Hi there,
Excellent work, but I've found an issue when this is used within a paper-dialog which has the 'backdrop' tag.

Symptoms:

1. The core-overlay that should be triggered when the menu is shown appears behind the paper-dialog instead of between the paper-dialog and the paper-fab-menu
2. When the paper-dialog is closed, one of the core-overlay-layers retains the class "core-opened". This means that a transparent overlay stays open above the rest of the ui, so that the user can't interact with any components! I don't know whether the one that is left open is from the dialog backdrop or the paper-fab-menu

I'm trying to find a fix/workaround for this but so far I haven't been able to

When using an icon other than the menu icon, the paper-fab-menu displays the menu icon until toggled on and off. Adding this fixes it

domReady: function() {
this.$.trigger.icon = this.icon;
},

Any plan for migration?

can't seem to be able to add link attributes to each paper-fab-menu-item

When the menu is in the open state, it takes up the items + fab button's area. This is fine, because the user expects that clicking on them registers to the fab menu element. However, when the menu is closed (with only the fab button showing), the area still covers the items. Trying to click on an element behind it registers on the fab menu instead, which is counter intuitive because there's nothing there.

We're using other things with overlays in our application but paper-fab-menu has a default z-index: 10000 which causes it to always be on top.

I'd rather see that you put the paper-fab-menu in an element with the correct z-index already, and the menu just takes care of itself when activated.

For a quick fix, I'd recommend moving the rule

.container {
  z-index: 10000;
}

down to a

.container.show {
  z-index: 10000;
}

rule to make sure it only elevates above everything once activated.

I guess this is somewhat related to #2 as well.