cvillaluz81 / bpbible Goto Github PK

Users should be able to unlock modules by providing an unlocking key

What steps will reproduce the problem?
1. Run bpbible.exe
2. Close the program

What is the expected output? What do you see instead?
Menus are not the normal ones. I have file, options, window, debug, and help.
Also, in KJV I do not have Strong's support, and the gospel harmony appears
to be missing (unless I just don't know what to look for).

What version of the product are you using? On what operating system?
0.2 on Windows XP. I also have python 2.5 installed along with wxwidgets
2.8. Version 0.1 of Bpbible worked fine.


Please provide any additional information below.

This is written to the error log on startup:

Traceback (most recent call last):
  File "wx\_core.pyc", line 14368, in <lambda>
  File "mainframe.pyc", line 140, in setup
  File "mainframe.pyc", line 536, in set_menus_up
  File "mainframe.pyc", line 621, in fill_options_menu
NameError: global name 'help' is not defined
Traceback (most recent call last):
  File "wx\_core.pyc", line 14368, in <lambda>
  File "auilayer.pyc", line 216, in update_all_aui_menu_items
AttributeError: 'MainFrameXRC' object has no attribute 'windows_menu'

Upon exit, this is appended:
Traceback (most recent call last):
  File "mainframe.pyc", line 477, in on_path_manager
  File "mainframe.pyc", line 621, in fill_options_menu
NameError: global name 'help' is not defined
Traceback (most recent call last):
  File "mainframe.pyc", line 470, in on_widget_inspector
AttributeError: 'MyApp' object has no attribute 'ShowInspectionTool'

Why is this feature needed?
Because users want to be able to include their own information and their
own notes, not just read the existing notes.


What problem will it solve?
Users not being able to make notes.


Some typical uses of the feature:
1. Make notes about a particular topic, including references to the
different verses (e.g. a Bible dictionary).
2. Enter notes about a verse.
3. Add additional cross references for a verse (e.g. TSK).


Are you aware of any programs that have this feature or a similar feature?
Most Bible software programs have some form of user editable content.

What steps will reproduce the problem?
1. Open the history tree
2. Open a different reference

The tree should update. It doesn't. Clicking on it causes the tree to update.
The same is true when selecting an item in the tree

Showing scripture references in tooltips would be much more useful if it
were possible to show the context of the reference.

I suggest adding a button to scripture reference tooltips, "View in
Context" or something similar, that when clicked shows the context of the
reference.  For bibles with paragraphs or section headings, these would
make logical units for a reference's context.  For Bibles without this,
other means would need to be employed.

Currently it mostly works on Mac. However, a few things are broken:
PopupWindow is not implemented under wxMac. This means module popup,
dictionary popup, autocompletion in copy verses doesn't work.

Toolbar on mainframe should be proper mac toolbar, not aui ones.

QuickSelector doesn't work properly.

Also, needs proper mac packaging (using py2app)

Allow the list of modules used in module comparison to be reordered.

What steps will reproduce the problem?
1. at any Bible verse, select first translation (or click near top of
second trans.) from drop-down list above Bible window
2. translation is properly changed but tab with book-chapter reference
immediately below it is also selected (I'm not double-clicking) so that
verse I was studying is changed.

What is the expected output? What do you see instead?
expected: translation only should change
instead: translation changed but also book-chapter changed

What version of the product are you using? On what operating system?
version .4 on WinXP Home (no problem on ver. .3 since there's no drop-down
changing of Bible translation)

Please provide any additional information below.
Bible version I'm changing to is one I created from another source, not one
available for download @ crosswire.org
possible fix:  make book-chapter tab list not as wide as entire Bible
window: make left border of that set of tabs even with right border of
drop-down list of translations.

PS: not related, but thanks for putting in keyboard shortcuts to navigate
chapter & verse -- it's the biggest reason I'm coming to favor bpbible over
The Sword Project.

It would be nice to have a way of viewing cross-references inline, by
exanding and contracting them in some ways.  While the existing tooltip
support is good, it suffers the following problems:
1. When you intend to bring them up, tooltips take too long to come up.
2. Sticky tooltips clutter up the screen and come up on top.  If you want
to look at more than one of the references they are very cumbersome to manage.
3. Sticky tooltips are a little too far away and distinct from the thing
that they are about (by being in a separate window), destroying the
locality a little.

What steps will reproduce the problem?
Download and install the WLC hebrew file from SWORD.
If you open any book in the Hebrew Bible, the words are displayed in the
correct order, but backwards, since Hebrew reads from right to left. So
Genesis 1:1 has the words in teh correct order if you read them backwards
(from left to right).

What is the expected output? What do you see instead?
It would be nice if we saw correctly arranged Hebrew. That is,
NOW: word 1, 2, 3, 4, 5, etc.
It should be: 5, 4, 3, 2, 1 (starting on right side).
It should also be right justified, rather than left justified.

What version of the product are you using? On what operating system?
Windoze XP.

Please provide any additional information below.
Reformatting text is very difficult (word wrap, etc.) and I don't know if
there are open source tools for doing this. The system should recognize
that the language is Hebrew and change the way it displays information
automatically.

What steps will reproduce the problem?
1. Help, Download Books 
2. Download the Personal Commentary from the Commentaries Section
3. User is unable to add comments as stated, and intended.

What is the expected output? What do you see instead?
I would expect to be able to click in the commentary and add my comments.
Instead the contents cannot be modified.

What version of the product are you using? On what operating system?
0.3.1 on Windows XP

Please provide any additional information below.
This is great software and I appreciate all of your hard work on it. I feel
that this modification would be appreciated by anyone who likes to make
their own notes while reading the Bible. Thank you for you time and
consideration of this request.

Preferences and user created data should be stored by default in a home
directory (probably ~/.bpbible) rather than in the data directory of the
BPBible application.  This means:
1. All such data is specific to a particular user.
2. There are no problems with permissions if the application directory is
not accessible to the ordinary user.
3. The data and preferences are accessible to new versions of the software
when new versions are installed.

If this is done, then it must be possible to upgrade preferences when a new
version of the software is installed.  Probably all preferences should be
versioned in some way.

What steps will reproduce the problem?
1. Open BPBible
2. Maximize
3. Minimize
4. Close
5. Reopen

What is the expected output? What do you see instead?
It should be maximized. Instead, it is as small as possible.
There are also problems where maximized windows will not restore to
previous size after closing and reopening.

This was observed under win2k

The system must support internationalisation. 

this is (mostly) a joke

What steps will reproduce the problem?
1. Uncheck "expand cross-references"
2. Hover over a reference
3. Crash

What is the expected output? What do you see instead?

Expect reference. See error

What version of the product are you using? On what operating system?

0.4 Windows XP

What steps will reproduce the problem?
1. open search dialog and make the search text input box active for typing
2. Alt-Tab to another progam
3. Alt-Tab back to BPBible search dialog

What is the expected output? What do you see instead?
I would expect to be able to continue typing into the search text control,
but instead, all keys are fed to the main window.

What version of the product are you using? On what operating system?
BPBible Version 0.3.9.6 on Vista Ultimate.

Please provide any additional information below.

I don't think this is a new problem.

What steps will reproduce the problem?
1. Make a few searches.
2. Exit BPBible
3. Open BPBible and go to the search window again.  Look at the list of
past searches.

What is the expected output? What do you see instead?
I would expect to have a list of the searches I have done (or at least the
recent ones).  Instead, I get an empty list.

What steps will reproduce the problem?
1. Set 2 bibles for the compare verses - one should have footnotes
2. The non-footnotes one should be set to use a different, larger font, and
then selected as the main bible.
3. Go to a verse with footnotes in the footnotes translation and Hover over
the footnotes. 

What is the expected output? What do you see instead?
Font will be as for the non-footnotes, rather than the footnotes.

When a permanent tooltip is created and requested to stay on top, it stays
on top of other application windows, rather than just on top of BPBible. 
This may not be expected by the user (and is made worse by the fact that
the permanent tooltip cannot be minimised).

I can't bookmark verses I want to come back to! Any chance of adding a 
quick bookmarking box

Find a large passage you wish to copy (Psalms and other poetry are good,
since they will typically take two or more screen lines for every verse. 
If using something like the ESV you can also get headings and paragraphs to
take up space).  Try to copy that passage by selecting it and using quick
copy.  Unless you are very careful, some of the passage will be off the
screen, and you are unable to select it.  If you are trying to copy a
passage that takes up more than one screen then it is not really possible
to copy it this way, but I find it the most direct way of copying the part
of the current chapter I am in for later reference.

In order to be consistent with other similar applications supporting text
selection in a scrolling window I think it should begin gradually scrolling
down when you approach the edge of the Bible pane and hold it there (this
applies to all of the pains, but especially to the Bible pane in view of
the quick copy feature (and in the future tagging) working with selection).

What steps will reproduce the problem?
1. Open the application from a clean subversion copy.
2. Exit the application.

What is the expected output? What do you see instead?
The program is expected to exit.  Instead, it gives an OSError on saving
settings if the data directory does not exist. 

What steps will reproduce the problem?
1. Select a Bible version that has not been indexed.
2. Search for something in that version using s from the Bible window
(since only indexing is permitted in the search dialog).

I would expect the software to search.  Instead, it:
1. Says that you cannot run a search on the software, since you haven't
indexed the current Bible version.
2. Informs you that a search index does not exist, and asks you if you want
to create an index.
3a. If you choose not to index the Bible, then it displays the search
dialog saying that 0 results were found, which isn't really correct because
no search has been made.
3b. If you choose to index the Bible, it builds an index, but then does not
perform the search (showing 0 results as before).  This is very misleading.

There are a couple of options to fix this:
1. Fall-back immediately to Sword search if there is no index from the 's'
key (slower, but at least it should work).
2. Give the user the option of building the index, or of falling back to
Sword (this would probably be a good general option for the search dialog).
 Something along the lines of "This module has not been indexed for
searching.  Indexing will make search much faster.  Do you wish to index
the module?", changing the settings to a standard SWORD multi-word if they
choose not to index the module.

In either case, the notification that the search will not be performed
should be removed, and the search should always be performed in some form.

At present, it is only possible to search from a search pane with lots of
options.  Viewing a verse in the main pane dismisses the search pane,
making it hard to look at a lot of verses in the search results in their
context.

I think that one possibility which would be a big improvement (though not
perfect) would be to have a simpler search with fewer options in a sidebar
(but able to be docked and undocked if desired), so that it would be
possible to view the search results at the same time as viewing each
passage in the search results in the main Bible window.

The list of references in the history window doesn't scroll down as new
references are added to it.  This means that after you have gone to a lot
of references in a session you can no longer see the current reference and
the recent references.

What steps will reproduce the problem?
1. download the arabic bible (AraSVD)
2. install
3. open

What is the expected output? What do you see instead?
it should read the same as Hebrew from right to left. it display from left 
to right

What version of the product are you using? On what operating system?
version 0.4 portable edition, OS = Windows XP

Please provide any additional information below.

At present, there is no good way to get out of the search window other than
clicking close.  ESC should close it.

There is a need to set the font per module/language.

There are two levels of difficulty here:
1. One font for all of a module based on the main module language.
2. One font for each language in the module. This is much more difficult.
A module like TSK has greek, hebrew and english text. Hebrew text should
use the Hebrew font.

1 should get into 0.4. 
2 may be special cased for greek and hebrew (which should be reasonably
easy to identify, and the most likely case).

The system must support internationalisation. 

This's rather a suggestion, not an issue. If you got a forum, i'll post 
there.

I like the WEB version organization of the verse. Each one of them is 
listed as a separated paragraph. That looks elegant, far more better than 
the other's run-together layout, say, KJV.

Would you please add a 'forced mode' for any version of Bible, to show 
each verse on its own block?

Thanks!

What steps will reproduce the problem?
1. Click "search"

What is the expected output? What do you see instead?
The expected output is the search window. What I saw was nothing - nothing 
popped up. It was the the "search" item had no function attached to it.


What version of the product are you using? On what operating system?
0.4 (Portable), Windows Vista HomePremium

Please provide any additional information below.

We need to be able to search for text in the current window (e.g. the
current chapter, dictionary entry, ...).  Search should use a standard
highlighted incremental search and key sequence (scrolling to the match and
highlighting) and should be case-insensitive, like Ctrl+F in Firefox,
Acrobat Reader, ...

I apologize in advance for being really nitpicky.

Open a module that doesn't have an index.
Create an index when prompted.
After indexing is completed, click close.
bpbible immediately loses focus.

What steps will reproduce the problem?
1. Resize the Books panel (or any panel that's on the left side.
2. Maximize any other panel.
3. Restore the panel that was maximzed.

What is the expected output? What do you see instead?
- The Books panel should be the same size as before but it returned to the
default size.


What version of the product are you using? On what operating system?
v0.3.1 Portable on Windows XP SP3

(Reported by Barry Drake) Linked verses as used by Sword are not supported
properly, meaning that any linked verses will occur several times in the
output.

What steps will reproduce the problem?
1. From the Bible window, type 'g' or 's' to bring up the relevant thing.

What is the expected output?
The thing that pops up to type into should display a caret to show the user
that it should be typed into.

What do you see instead?
The box appears without a caret.  The user may then be confused, unsure
what they should do with this box that has popped up.

What steps will reproduce the problem?
1. Bring up a permanent tooltip for a reference with Shift-T or anchoring a
tooltip from a cross-reference.
2. Type in a new reference (e.g. gen 3:5).
3. Click "Go to verses"

What is the expected output? What do you see instead?
The expected output is to change the tooltip text from your current
reference to Genesis 3:5.

What actually happens is that you see the title bar change to Genesis 3:5,
but the reference not changing at all.

It would be good if the user right clicks on a word to display in the submenu:
Submenu 1: Look up in Dictionary
  Menu items are dictionaries this word is in, when clicked on, they look
it up in dictionary
Submenu 2: Search for this in Bibles
  Bibles this can be search for in
  When clicked on, it launches search.

Case 1 should be easy enough to do - but should be a bit smarter.
Its smartness could include:
Stemming
Liquors would go to Liquor in the ISBE.

Partial key matches: 
Jacob would go to Jacob (1) in ISBE

Use of the underlying strong's number if there (for example, in KJV, it
should include a strong's lookup for the word)

Case 2 would require much faster loading of search results (or at least the
wordlist - it would necessarily need to load all of it).
Also, unindexed bibles might cause problems

As many users use portable devices with low disk space, many want to delete 
modules. There should be a way to do this easily.

What steps will reproduce the problem?
1. Open BPBible (latest SVN) with the ESV.
2. Search for "face shine"

What is the expected output? What do you see instead?
I expect to see a list of references with previews of the reference (and
get it).  However, the preview for Psalm 67:1 is "<p><h4 class="heading">To
the choirmaster...", without the HTML being removed.  It displays correctly
as a heading in the bottom preview pane.

What steps will reproduce the problem?
1. (optional) Index a module with a non-latin (i.e. Unicode) script. (e.g. 
Ukranian, Hebrew)
2. Copy some text from such a module and search for it.
3. Search for that text!

What is the expected output? What do you see instead?
Nothing happens.  Look at bpbible.exe.log or stdout to find the traceback 
info.

---
Traceback (most recent call last):
  File "search\searchpanel.pyc", line 274, in on_search_button
  File "search\searchpanel.pyc", line 288, in on_search
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-4: 
ordinal not in range(128)

---

Templates have changed to backend.verse_template.Template instead of
util.util.Template. Pickles from 0.3 will reference the old item. Perhaps a
search and replace of the pickle text will do it?

What steps will reproduce the problem?
1. Add topic
2. Try to delete
3. Nothing happens


It appears that none of the cut copy and paste operations are working either.

OK, these functions do work, but not from the right-click menu.

A permanent tooltip behaves differently from a Bible frame in several ways.

1. Ctrl-Shift-C will just copy the selected text (with links if any) rather
than copying the selected verses as it does in the main Bible Frame.

2. In a similar way, the Copy All button on a permanent tooltip copies the
exact text of the tooltip, rather than using the Quick Copy formatting
(which I suspect people are more likely to want).  It is also notable that
the Copy All button disappears when a tooltip is anchored, which may also
surprise users.

3. The 'g', 's' and similar shortcut keys do not work from within permanent
tooltips.

All of these things mean that the user has to treat permanent tool-tips as
somehow different from the Bible Window, which I am not sure that they
should have to.

1. Do a fresh installation of BPBible. (Optional)
2. Don't add any SWORD modules/remove all paths/have no modules.
3. Try to exit (file menu or x button in title bar).  It should have
closed.  It didn't, and chucked an error (stored in bpbible.exe.log)
4. Try to "Copy Verses" - that chucks more errors.

E-sword puts a information graphic on the tabs for dictionaries and
commentaries which contain the given key/verse. This would be good to have
in the module drop-down.

Getting this info for dictionaries is relatively easy; commentaries may be
a little harder. Possibly checking for empty text will do it.

It has been requested that we add support for printing from commentaries
and personal notes on the forums (http://bpbible.com/node/59).

I think this is a fairly low priority since there is a reasonable
workaround (copy into another program and print from there).  However, it
might be convenient to support printing.

What steps will reproduce the problem?
1. Start a Sword search
2. Move over a footnote

Traceback (most recent call last):
  File "/media/disk/python/bpbible/gui/htmlbase.py", line 515, in MouseMove
    self.Idle(None)
  File "/media/disk/python/bpbible/gui/htmlbase.py", line 663, in Idle
    self.OnCellMouseEnter(cellover, xx, yy)
  File "/media/disk/python/bpbible/displayframe.py", line 143, in
OnCellMouseEnter
    protocol_handler.on_hover(self, href, x, y)
  File "/media/disk/python/bpbible/protocols.py", line 22, in on_hover
    self._handle(self.hover, frame, href, x, y)
  File "/media/disk/python/bpbible/protocols.py", line 32, in _handle
    d[protocol](frame, href, url, *args)
  File "/media/disk/python/bpbible/displayframe.py", line 207, in on_hover
    data = bible.GetFootnoteData(module, passage, value, "body")
  File "/media/disk/python/bpbible/backend/book.py", line 288, in
GetFootnoteData
    def GetReferencesFromMod(self, modname, ref, context=None, max_verses=-1):
  File "/afs/monash/users/b/p/bpmor3/lib/python2.5/site-packages/Sword.py",
line 248, in __getitem__
    def __getitem__(*args): return
_Sword.AttributeTypeListMap___getitem__(*args)
IndexError: key not found


The module carries the entry attributes as state around with it. This can
cause problems with lots of things.

A dialog to help a user construct a search would be good to have in 0.4 as 
some of the searches are getting a little more complex.

This could be a tabbed pane (hoping for fixed width fonts to display this):
 __________________________________________________________
|                                                          |
| Search: (Your search will appear here)                   |
|______                                                    |
|Words | Strong's | References                             |
|      +----------+----------------------------------------|
| (?) All of these words: ________ AND _______ AND ________|
| (?) One of these words: ________ OR _________ OR ________|
| (?) This phrase:        _________________________________|
| (?) This exact word:    _____________                    |
| (?) Word starting with: _____________                    |
| (?) Regular expression: _____________                    |
|                                                |Search|  |
|__________________________________________________________|

An example filled out might look like this:
 __________________________________________________________
|                                                          |
| Search: Grace mercy "Lord Jesus Christ" bapti*           |
|______                                                    |
|Words | Strong's | References                             |
|      +----------+----------------------------------------|
| (?) All of these words: Grace___ AND Mercy__ AND ________|
| (?) One of these words: ________ OR _________ OR ________|
| (?) This phrases:      Lord Jesus Christ_________________|
| (?) This exact word:    _____________                    |
| (?) Word starting with: bapti________                    |
| (?) Regular expression: _____________                    |
|                                                |Search|  |
|__________________________________________________________|

Examples of this type of form are google's advanced search 
(http://www.google.com.au/advanced_search?hl=en) and BibleDesktop's