curiositry / mnml-ghost-theme Goto Github PK

Hi,

Paragraphs in the editor have a margin big enough to create a visual gap and thus visually separate blocks of text.

but on a post page, they're closely aligned to each other:

I guess this is closer to what I will get by pressing "control+enter" in the editor, i.e. a "soft break", probably?

Would you think it makes sense to add a visual gap between paragraphs as in the editor?

Thank you for all the work!

And maybe use firesize.io for image resizing

I'm opening way too many issues today, aren't I?

Anyway, see this twitter thread.

Reproducible by opening https://blog.alfiepates.me on a 360px-wide "mobile device" using the Google Chrome developer tools.

This will arrive by Ghost 0.8, when menus will be supported without hardcoding them in.

Hi!

I noticed something more in the theme. Could it be possible to add more sharing buttons? I mean, LinkedIn, Reddit, Tumblr, maybe Pocket and Pinterest too.

And, another thing. I don't know how to add more buttons at the footer. I tried, but I couldn't. Could you explain this, please?

I try to help you with the Wiki about all that stuff, so people go there and see the information :)

Thank you for your attention!

Hi,

How to type inline math with the Katex?

One way I was typing math, was to use code injection (on Ghost Pro). In the head, I included the snippet:

<script type="text/javascript"
  src="https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML">
</script>

Then, I could use (almost) standard MathJax syntax to include math: [ ... ] or $$ ... $$ for display math and ( ... ) for inline math.

But if I apply mnml theme, the math elements get scroll bars around them. And I don't know how to modify the theme for Pro usage.

I have other questions about using the theme for Pro, such as how to create navigation, but will create a separate issue for that.

pages doesnt contain hover menu.

And defer it so it doesn’t slow anything down.

• Figure out how to apply it to anything between $$ and $$

It appears that firesize.com is no longer up and resizing images. You can see this on the sample page for mnml: here. I first noticed on my mnml blog pearoftheweek.com. Thanks

MNML get’s grade A on GTmetrix, and similar on other speed tests I’ve run it through … but it can still be faster. The one warning from Google’s pagespeed insights: defer loading of non critical css and javascript.

I’ll try to have this done by v3.0.0

To be deferred:

• Prism.css
• Prism.js
• FitVids.js
• KaTeX (once added)
• Icon font
• Any other 3rd party add-ons

I think this is a useful feature to have because it has the potential to increase reader engagement levels on my blog.

Tag page has serious issues. Need to make it match the author page.

It looks as though the current theme will not display data inserted in {{ghost_head}} and {{ghost_foot}} from the code injection page.

I adore this theme but I think the default paragraph spacing is a little to small to make paragraphs separated enough for long blogposts not to feel like impenetrable walls of text.

(For example, I just published this blogpost)

Again, I do think this theme is brilliant, it's by far my favourite out of all the themes I've taken a look at. Thanks for building it :)

(Additionally, I think titles/headers could do with some rework but I'll open a separate issue for that.)

The current modal menu is substandard. It needs to be replaced with something that doesn’t take over the whole screen, but is still responsive and can handle different numbers of links.

I was trying to translate your theme using: https://ghost.org/blog/theme-translations/
but with no effect. I have added all the files described in the guide and I was replacing strings with translation helper {{t "some string"}}
What is missing?

Ghost will probably integrate comments eventually, but until then it’d be nice to make an easy way to integrate a 3rd party service. Current options:

• Disqus
• NodeBB (not good for most people, as you have to install a forum)
• Intense Debate

Hi,

I’m running the latest MNML (right from the master) on my blog and have a problem with shrunk YouTube video widget https://kurtov.pro/blog/p/c1b229f9-5388-4246-90db-4a60927381fe/

If I manually set height and width properties on the iframe element in the dev tools then it’s all fine https://imgur.com/rVNxvEM

Is this a problem with a theme and if yes - how do I fix it?

The hanging punctuation hangs a bit too much to the left when displayed on Chrome on Android, which causes the numbers to appear partially offscreen.

Fatal Errors
Must-fix to activate theme

Replace {{@price.monthly}} and {{@price.yearly}} with {{price monthly_price currency=currency}} and {{price yearly_price currency=currency}} after fetching tier data with {{#get "tiers"}}
There is no longer a global @price object. You need to use {{#get "tiers"}} to fetch all the tiers and get access to the {{price monthly_price currency=currency}} or {{price yearly_price currency=currency}} for each tier
Find more information about the {{price}} helper here.

Affected files:
members/signup.hbs: {{@price.monthly}} and {{@price.yearly}} should be replaced with {{#get "tiers"}}

In the second paragraph of the README, the latest Ghost version is incorrectly mentioned as v5.3.0, it should be v0.5.3.

Add this as an option, and defer it do it doesn’t slow anything down. Options for plugins:

• https://github.com/michael-lynch/reading-time
• https://github.com/themeskult/jquery-reading-time

The default top-level header size is way too big. It's even bigger than the blogpost title!

I think the entire set of header sizes could do with a bit of re-kerjiggering so that they flow slightly better with the body of the post, instead of being GIANT WORDS IN THE MIDDLE OF YOUR BLOGPOST, as they are currently.

See this post for an example.

I am updating my blog from 2017 era mnml to current (and also from similarly old Ghost version to current), and ran into one issue.

I can't get the secondary navigation, at the bottom of the page, to show up. Initially I thought this is due to some editing error on my side, but it also does not show up for me using the version at current master. Instead, it only shows up if I change partials/footer.hbs to not include the navigation with type="secondary".

Looking around in the commit history, I see that 022e3ec mentions that the ifSecondary helper is buggy; is this perhaps related?

Hi,

I love your theme for Ghost. I've installed it and gotten most things working except two: I cannot create /about or /contact pages. I created a static page in Ghost called /about but it doesn't seem to get picked up by the menu like it should. You can check out my blog here to see what I mean: www.war-mango.com. Try navigating to /about to see that the page exists but it won't show up in the menu. Could you please help me? Thank you.

Generally speaking it's not a huge issue to do this; I understand the appeal of not requiring a build step for users -- being able to drop this code directly into a ghost instance lowers the bar of entry significantly. However, this generally considered bad practice for a number of reasons.

Instead, the dependencies should be linked w/ npm/yarn/whatever package management tool and the build should be served w/ a "release". Specifically, stuff like FitVids and prism.js should be removed from this repository and linked with npm.

This does add a build step, but is actually a much better experience for contributors and end users will have a succinct build history to download from. If you are interested in incorporating something like this I can submit a pull request. I plan on forking this and adding a couple bells and whistles (gulp to pre-process css/js for example).

While KaTeX's renderer is very fast, it is also more limited than MathJax's (e.g. no newcommands, generally worse handling of scaling, and last time I tried things like equation labels didn't work either). On my own blog I ended up switching, because KaTeX was not able to render some very math-heavy posts, while MathJax 2.7 took its time but ended up with proper result.

Since MathJax 3 fixes the worst pain points about the previous version (rendering is much faster, there is no longer annoying flickering as the renderer redraws every formula), I think it is worth considering either switching to MathJax, or making it a selectable alternative.

Hi! Is it supported in some way to change the orange color of the titles and stuff? Is it possible to do some sort of code injection to make it change to lets say black color?

So there isn’t duplicate content, the data is just pulled out bu the theme.

Hi!

I like the theme a lot, but I don't like the menu. I still don't know how to make things in Ghost's themes, so I'll ask here: is it possible to add an option to always show the menu instead of the button to open and close it?

Of course I know it's possible modifying the theme, but I'm sure there's people who likes it.

Thank you in advance!

There’s no easy way to tell if the image in the {{image}} helper was uploaded by the user into the content folder, or if it’s linking to an external image. This means that, right now, post thumbnails only work with remote images, because firesize needs an absolute URL.

I need to find a way to check if the image is local or remote, and prepend the blog url if it’s local — until the {{image}} helper becomes an actually helpful helper.

Hi. How do you handle display mode for math rendering with Katex?

Hi, I'm a long-time MNML user (although haven't updated in a while because of my own customizations). I was looking at the latest version and it looks pretty slick -- I might update to it soon.

I noticed one thing that could perhaps be improved: the animation for the navigation menu feels quite slow and is significantly longer (1 second) than what's generally recommended (250-500 msec). Here's some scientific justification for using a shorter duration.

Let me know your thoughts.

• Disallow /ghost/
• Disallow indexing of /tag/ urls

Either with javascript, or data-img and css background image

Hi,

I followed the official tutorial on adding syntax highlight https://ghost.org/docs/tutorials/code-syntax-highlighting/ and installing Prism seems to skew font size in the code blocks

If I disable font-size: 1em; setting for code[class*="language-"], pre[class*="language-"] everything seems to be ok, but I'm not good with CSS at all.

Can you please help me out with fixing this?

version: mnml (mnml-ghost-theme6.0.1)

Hi,
I’m the owner of play-with-ghost and one big feature I'm working on is to showcase templates I enjoy like yours.

Let me know if I can help you by hosting a staging environment of your Ghost project(s) or anything related of the backend of hosting Ghost.

Cheers!
Pascal

First of all, thank you @curiositry for this cool theme!

I spotted a style problem with the headings, which I think was caused by changes introduced in Ghost 1.0+.

Here's what a heading looks like in Mnml's demo page:

Here's what it looks like in Ghost 1.5:

Apparently it's because the post content now resides in a .kg-card-markdown div:

Which makes the following CSS rule inapplicable: