cuadue / 2048_game Goto Github PK

In case anyone is running this anywhere else (*BSD, mac, distros using musl/...) the tests
will fail because srandom() can be (and is) implemented as the authors of the C library wish.

Simplest solutions:

• ignore
• just warn :)
• use rand48 (worse than random, so maybe only for "-s", but it's the only standard prng which specifie BOTH the generator AND the seeding procedure)

$ grep rand *.c
int loc = random() % num_zeros;
lboard[i] = random() % 10 ? 1 : 2;
srand(time(NULL));

This happens to work as intended because the glibc implements rand/srand using random/srandom, so seeding rand also seeds random, but people using any other C library will find your game pretty repetitive :)

When losing, the board isn't always 100% full. I can see that if a 2 was placed into the open slot, then I could move again. Apparently a 4 was dropped, but it's not being displayed. Not sure if there is a problem detecting a loss, or a problem displaying the board after a loss.