csteinert / friends-of-gdic Goto Github PK

3.0 5.0 10.0 41 KB

A simple project to practice using Git and creating pull requests!

License: MIT License

HTML 73.12% CSS 26.88%

girl-develop-it newcomers html css

friends-of-gdic's Introduction

Friends of Girl Develop It Columbus

A simple project to practice using Git and creating pull requests! We're compiling a list of the names of the wonderful people who make up this organization. Are you one of us? Please add your own name to the list!

View the list here!

How to Contribute

Check out the issues for ideas of things to do with this repository! Adding your name to the list is just one of the options here! If you think there are other improvements that can be made to the project that aren't listed in the issues... add a new issue!

This README is, itself, incomplete! I'd love some help adding resources for those folks who are new to Git/GitHub. Please feel free to contribute to this portion of the project as well!

Some Resources

To Git Started... (contributing to the project)

If you have a Git installed and a GitHub account, you're ready to get started.

Fork the Repository

Click the fork button to create a copy of the repository in your GitHub account.

Clone the Repository

In your forked repository, click the "Clone or Download" button. Copy the link to your repository.

you can tell that if the repository is yours if the link says https://github.com/<your_user_name>/friends-of-gdic

Open the console. Navigate to the folder you want to place the repository (if necessary). Using the command console, enter the following command: git clone <link to your repository>

And Voilá! The repository is cloned to your computer!

friends-of-gdic's People

Contributors

Stargazers

Watchers

Forkers

parkerdyer melissa3000 amayahuman gtkpr maryeb sabrown84 shiraz1 bonwalton underhood31

friends-of-gdic's Issues

Add spacing between list items.

The list items (<LI>) elements are too close together, in my opinion:

Add some space between the LIs using CSS. (Margin? Padding? Your choice!)

Add a fun background to the page!

The index.html page is currently white and blank and sad. Find a fun repeating background (maybe create one on http://bgpatterns.com/ ?) and add it to the body via the styles.css file.

Make sure the text is still legible with the new background! (Tip: setting a background color on main may help with this, and don't be afraid of RGBA values!)

Footer scroll issue

The footer is fixed so that it's always on the bottom of the screen, which is perfect I love it. Unfortunately, it has the potential to cut off the bottom of the list (on smaller screens, once the list gets long enough) in its current state.

In the below image, I created the test scenario by copy-pasting a bunch of LI elements to fill out the list, and then used the Inspector in Chrome to see if any of the elements were covered.

There's a few different ways to fix this using just CSS, pick whichever one works best for you!

Add a link back to the repository at the bottom of index.html

Since this has been published as a github-dot-io page (https://csteinert.github.io/friends-of-gdic) I'd like to have a link on the bottom of index.html to help people find their way back to the repository (https://github.com/csteinert/friends-of-gdic).

Add the DOCTYPE!

Ack, there's no DOCTYPE on index.html! Please add one.

More information about DOCTYPE here: https://developer.mozilla.org/en-US/docs/Glossary/Doctype

Change the fonts

I've picked out the two fonts I like. Link to them in index.html and set the correct styles in styles.css!

I would like the header fonts (h1 and h2) to be in Patrick Hand SC:
https://fonts.google.com/specimen/Patrick+Hand+SC

And I would like the body text to be in Source Sans Pro: https://fonts.google.com/specimen/Source+Sans+Pro

Add your name!

Use the template (the commented-out section in the index.html file) to add your name to the end of the list!

Create variables for colors

Now that we have access to custom CSS properties (variables! woo!) let's add some for the colors in the app. Here's some info on custom CSS properties: https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables

Steps:

Create variables for --black and --white in styles.css
Replace all instances of those colors in styles.css with their respective variables

Add info on how to clone a repo to the README

It would be helpful to folks who are new to Git/GitHub if there was a bit more information in the README.md file about how to clone a repo to their computer and begin working on it. Written documentation or a link to an existing explanation would be great.

Update the header design

Now that we have a legit header (thanks @parkerdyer!), I'd like the H1 element to be inside of it, and have the logo and text be centered.

Add info on how to submit a pull request to the README

It would be helpful to folks who are new to Git/GitHub if there was a bit more information in the README.md file about how the pull request process works. Written documentation or a link to an existing explanation would be great.