cssstats / get-css Goto Github PK

View Code? Open in Web Editor NEW

36.0 5.0 15.0 2.71 MB

Moved to monorepo

Home Page: https://github.com/cssstats/cssstats/tree/master/packages/get-css

License: MIT License

JavaScript 100.00%

get-css's People

Contributors

Stargazers

Watchers

Forkers

johno davidmatas augbog autarc faebeee layoutanalysis ti0ma avantio rsoury vprasanth yaaqoub worie pachirulo wjx0820

get-css's Issues

Pass options along to the request module

Result of the discussion from #6

Doesn't work for microsoft.com

I suspect it's a result of not following redirects.

Doesn't resolve relative urls to css from .html files

cssstats/cssstats#133

Clean up index.js, break out some functions into the utils directory

Handle URLs to CSS files

Shouldn't this module also handle URLs that point directly to css files?

Actually this is handled in cssstats: resource.js

IMHO this should use the same request command like in get-css

Errors out with gzipped responses

Import statements produce duplicated CSS

See cssstats/cssstats/issues/130

Support for a CLI?

I think a CLI would be pretty useful. I've got a few different use cases where I'd like to do something like:

getcss http://foo.bar > foobar.css

Do you think this would be worthwhile to incorporate into this project? I'd be happy to submit a PR with the functionality above if you think it's worth it.

When there is no CSS to get, return an empty string rather than undefined

Allow timeout to be configurable via the cli

Imports aren't added to the correct location of a stylesheet

cssstats/cssstats#185

Ensure `resolve-link` handles undefined input

TypeError: Cannot read property 'match' of undefined
    at resolveUrl (/var/www/cssstats/node_modules/get-css/utils/resolve-url.js:4:10)
    at createLink (/var/www/cssstats/node_modules/get-css/utils/create-link.js:6:10)
    at Object.<anonymous> (/var/www/cssstats/node_modules/get-css/index.js:53:25)
    at exports.each (/var/www/cssstats/node_modules/cheerio/lib/api/traversing.js:294:24)
    at parseHtml (/var/www/cssstats/node_modules/get-css/index.js:51:27)
    at Request._callback (/var/www/cssstats/node_modules/get-css/index.js:133:7)
    at Request.self.callback (/var/www/cssstats/node_modules/request/request.js:198:22)
    at emitTwo (events.js:87:13)
    at Request.emit (events.js:172:7)
    at Request.<anonymous> (/var/www/cssstats/node_modules/request/request.js:1063:14)

Not working on www.getnoodl.es

Trying to use get-css on my own app, Noodles. The login page (http://www.getnoodl.es/login) has the whole application's CSS, but get-css returns Error: getaddrinfo ENOTFOUND getnoodl.es on it.

Add support for css imports.

Currently, get-css doesn't have support for CSS @imports, so no CSS shows up in a base file consisting of:

@import url(foo.css);
@import url(bar.css);

Additionally, CSS files with content and @imports are not receiving all the CSS the document contains.

If you'd like, @jxnblk, I can start tackling this in the next day or so. I suspect it will require some rejiggering of the index.js because one has to assume that any @imported CSS file could also contain another @import.

Thanks for the awesome work, by the way. This is an awesome module.