csdms / bmi-c Goto Github PK

The entry isn't used to build the project, and it may cause problems for a downstream project that takes information from the pkg-config file.

I am guessing that this function is part of the standard, so I expect to find a function

int BMI_Get_var_itemsize(BMI_model*, const char* name, int* dest);

in the bmilib.h file.

The pkg-config file output from CMake, bmic.pc, has relative paths:

$ cat /Users/mpiper/anaconda3/envs/bmic/lib/pkgconfig/bmic.pc
Name: bmi-c
Description: The Basic Model Interface for C
URL: https://bmi.readthedocs.io
Version: 2.0
Libs: -Llib -lbmic
Cflags: -Iinclude

Absolute paths are needed, otherwise downstream packages can't find bmi.h.

Make it look like the README in the bmi-fortran repo.

The header bmi.h here contains these macro definitions:

#define BMI_SUCCESS (0)
#define BMI_FAILURE (1)

The C++ header bmi.hxx contains declarations of variables in with those exact same names. Thus, if a source file says

#include <bmi.h>
#include <bmi.hxx>

It will fail to compile, because the compiler will see code that preprocesses to

namespace Bmi {
  const int (0) = 0;
  const int (1) = 1;
}

This is a potential problem for codebases that want to support BMI modules written in either language, and not have to meticulously separate where the two different BMI language binding headers get included, or in which order.