Comments (3)
First one is a bug.
The second one - I can't reproduce. My example:
post "/api/test" do |env|
if (token = env.request.headers["Token"]?) && (proto = env.request.headers["Proto"]?)
pp token, proto
end
end
I noticed you don't use the proto
var in this sample:
So the assignment is useless and properly reported. Can you double check and post the full sample?
Thanks for posting.
from ameba.
Yes, my proto
variable is not used, which is why. I am very sorry that I didn’t notice it.
What surprised me was that you actually looked through my code and found it. Very ashamed 😅
from ameba.
No problem. I will fix the issue reported in the first example. Thanks
from ameba.
Related Issues (20)
- `Lint/LiteralsComparison`: false positive when comparing tuple
- Failing spec on crystal master
- Replace `Performance/AnyInsteadOfEmpty` with `Style/EmptyInsteadOfPresent` HOT 9
- Regression in `Lint/ShadowingOuterLocalVar`
- Configure skipping directories HOT 3
- warn on redundant use of `.try` HOT 3
- Recognize unused variable from type declaration HOT 2
- ComparisonToBoolean with Bool unions HOT 2
- exception names are too limited HOT 7
- A dedicated `rules` command HOT 1
- `Lint/UselessAssign` reports type declarations within `lib` definitions
- Add lsp server option HOT 1
- `Lint/UselessAssign` when using generics HOT 9
- `Lint/UselessAssign` reports macros accepting `Crystal::Macros::TypeDeclaration` HOT 16
- Avoid annoyance from new rules HOT 4
- Naming/BlockParameterName + stdlib methods like sort HOT 4
- spec helpers getting flagged HOT 1
- Custom macro generates "Useless assignment to variable" HOT 3
- Naming/BlockParameterName with ignored names HOT 1
- Ameba trips on folder named `*.cr`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ameba.