Comments (7)
Yeah, in the same time rescue ex
has 6.9k occurrences (~10x more than rescue exc
) - i.e. all other uses are pretty marginal. I'm gonna add error
to the defaults though, since it was unaccounted for.
from ameba.
thanks mate!
from ameba.
Perhaps use cases such as ex_
prefix could be enabled with regex matching support?
from ameba.
I feel like this should include version common names like
error
It's not that common, therefore I didn't include it.
You can add it to your project's .ameba.yml
file.
it should probably add something like
|| begins_with?("#{allowed}_")
so nested exceptions can be handled likeex_parse
ex_io
etc
I disagree, exception variables should IMO have unified names.
Also
e
is not very descriptive ...
IMO it is - in the same way i
(for index) is.
... and breaks other rules like descriptive block naming.
It shouldn't, since it's explicitly whitelisted:
from ameba.
Seem pretty commonly used
https://github.com/search?q=%28language%3ACrystal+%29+AND+%22rescue+error%22&type=code
from ameba.
more common than rescue exception
from ameba.
also missing exc
which is also quite commonly used
from ameba.
Related Issues (20)
- warn on redundant use of `.try` HOT 3
- Recognize unused variable from type declaration HOT 2
- ComparisonToBoolean with Bool unions HOT 2
- A dedicated `rules` command HOT 1
- `Lint/UselessAssign` reports type declarations within `lib` definitions
- Add lsp server option HOT 1
- `Lint/UselessAssign` when using generics HOT 9
- `Lint/UselessAssign` reports macros accepting `Crystal::Macros::TypeDeclaration` HOT 16
- Avoid annoyance from new rules HOT 4
- Naming/BlockParameterName + stdlib methods like sort HOT 4
- spec helpers getting flagged HOT 1
- Custom macro generates "Useless assignment to variable" HOT 3
- Naming/BlockParameterName with ignored names HOT 1
- Ameba trips on folder named `*.cr`
- [Feature Request] Unused `rescue` variable name
- [Feature Request] Lint against accessing instance variables outside of the instance of a class HOT 4
- ameba no longer works in WSL
- Add rule enforcing explicit return HOT 5
- False positive `Lint/UselessAssign`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ameba.