Comments (5)
That's not a bug. Due to how the Crystal formatter works, Ameba can only show the error in the scope of the whole file.
Also, this concerns only Lint/Formatting
rule.
from ameba.
@Sija maybe we can remove that :1:1 at the end for this specific rule in order to avoid confusion?
from ameba.
@veelenga Since the Ameba's issues are attached to the Location
I don't see any clean way to do it.
from ameba.
Oh, well, actually we could show the line(s) with changes, but how would that work?
- Show just the first line changed?
- Show all of the lines changed, each one tagged as
Lint/Formatting
issue?
from ameba.
My idea is to have a new rule prop, let’s say scope which could be Point | Line | File and which defaults to Point. The formatter rule will override it to File. Then each Ameba’s formatter will properly format the output. What do you think?
However, it may break the flycheck formatter which is used by editors to point to the location.
from ameba.
Related Issues (20)
- warn on redundant use of `.try` HOT 3
- Recognize unused variable from type declaration HOT 2
- ComparisonToBoolean with Bool unions HOT 2
- exception names are too limited HOT 7
- A dedicated `rules` command HOT 1
- `Lint/UselessAssign` reports type declarations within `lib` definitions
- Add lsp server option HOT 1
- `Lint/UselessAssign` when using generics HOT 9
- `Lint/UselessAssign` reports macros accepting `Crystal::Macros::TypeDeclaration` HOT 16
- Avoid annoyance from new rules HOT 4
- Naming/BlockParameterName + stdlib methods like sort HOT 4
- spec helpers getting flagged HOT 1
- Custom macro generates "Useless assignment to variable" HOT 3
- Naming/BlockParameterName with ignored names HOT 1
- Ameba trips on folder named `*.cr`
- [Feature Request] Unused `rescue` variable name
- [Feature Request] Lint against accessing instance variables outside of the instance of a class HOT 4
- ameba no longer works in WSL
- Add rule enforcing explicit return HOT 5
- False positive `Lint/UselessAssign`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ameba.