Code Monkey home page Code Monkey logo

Comments (5)

Sija avatar Sija commented on September 26, 2024

That's not a bug. Due to how the Crystal formatter works, Ameba can only show the error in the scope of the whole file.
Also, this concerns only Lint/Formatting rule.

from ameba.

veelenga avatar veelenga commented on September 26, 2024

@Sija maybe we can remove that :1:1 at the end for this specific rule in order to avoid confusion?

from ameba.

Sija avatar Sija commented on September 26, 2024

@veelenga Since the Ameba's issues are attached to the Location I don't see any clean way to do it.

from ameba.

Sija avatar Sija commented on September 26, 2024

Oh, well, actually we could show the line(s) with changes, but how would that work?

  • Show just the first line changed?
  • Show all of the lines changed, each one tagged as Lint/Formatting issue?

from ameba.

veelenga avatar veelenga commented on September 26, 2024

My idea is to have a new rule prop, let’s say scope which could be Point | Line | File and which defaults to Point. The formatter rule will override it to File. Then each Ameba’s formatter will properly format the output. What do you think?

However, it may break the flycheck formatter which is used by editors to point to the location.

from ameba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.