Comments (8)
Ah, okay that is an interesting point. For this particular rule (PredicateName) that wouldn't be a case, because it is looking for the method definition, not the method call. So it will not report an error and there will be nothing to autocorrect. But there might be other rules which could do other inspections for third-party calls. Will keep this in mind, thank you.
from ameba.
in my project i have ~500 errors: LargeNumbers: Large numbers should be written with underscores
, replace it by hands is pain.
from ameba.
@kostya @anicholson any help is appreciated :)
Btw, LargeNumbers is now disabled by default in master.
from ameba.
Awesome! But how to handle the cases where problems comes from third-party shards?
from ameba.
We don't inspect third-party shards. lib/
directory is excluded from the list of sources.
from ameba.
Actually I was thinking in this case:
if OtherLib.has_something?
# ...
end
But I didn't realised Ameba only checks for methods definitions, not calls. Sorry!
from ameba.
Oh yes please! I don't want to use a linter that doesn't fix the things it knows how to :)
from ameba.
Closed by
from ameba.
Related Issues (20)
- Error on macro expansion when building with Crystal 1.9.0 HOT 2
- Fails to install on MacOS Monterey HOT 2
- postinstall ameba 1.4.3 on Crystal 1.9.2 failed with: Error: type must be Ameba::Severity, not (Ameba::Severity | Nil) HOT 1
- `--only` CLI flag appears to ignore excluded files within config HOT 1
- BUG: trying to downcast (Slice(UInt8) | Nil) (Crystal::MixedUnionType) <- Slice(UInt8) (Crystal::GenericClassInstanceType) (Exception) HOT 2
- `Lint/LiteralsComparison`: false positive when comparing tuple
- Failing spec on crystal master
- Replace `Performance/AnyInsteadOfEmpty` with `Style/EmptyInsteadOfPresent` HOT 9
- Regression in `Lint/ShadowingOuterLocalVar`
- Configure skipping directories HOT 3
- warn on redundant use of `.try` HOT 3
- Recognize unused variable from type declaration HOT 2
- ComparisonToBoolean with Bool unions HOT 2
- exception names are too limited HOT 7
- A dedicated `rules` command HOT 1
- `Lint/UselessAssign` reports type declarations within `lib` definitions
- Add lsp server option HOT 1
- `Lint/UselessAssign` when using generics HOT 9
- `Lint/UselessAssign` reports macros accepting `Crystal::Macros::TypeDeclaration` HOT 16
- Avoid annoyance from new rules HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ameba.