Code Monkey home page Code Monkey logo

Comments (8)

veelenga avatar veelenga commented on May 27, 2024 1

Ah, okay that is an interesting point. For this particular rule (PredicateName) that wouldn't be a case, because it is looking for the method definition, not the method call. So it will not report an error and there will be nothing to autocorrect. But there might be other rules which could do other inspections for third-party calls. Will keep this in mind, thank you.

from ameba.

kostya avatar kostya commented on May 27, 2024 1

in my project i have ~500 errors: LargeNumbers: Large numbers should be written with underscores, replace it by hands is pain.

from ameba.

veelenga avatar veelenga commented on May 27, 2024 1

@kostya @anicholson any help is appreciated :)

Btw, LargeNumbers is now disabled by default in master.

from ameba.

hugoabonizio avatar hugoabonizio commented on May 27, 2024

Awesome! But how to handle the cases where problems comes from third-party shards?

from ameba.

veelenga avatar veelenga commented on May 27, 2024

We don't inspect third-party shards. lib/ directory is excluded from the list of sources.

from ameba.

hugoabonizio avatar hugoabonizio commented on May 27, 2024

Actually I was thinking in this case:

if OtherLib.has_something?
  # ...
end

But I didn't realised Ameba only checks for methods definitions, not calls. Sorry!

from ameba.

anicholson avatar anicholson commented on May 27, 2024

Oh yes please! I don't want to use a linter that doesn't fix the things it knows how to :)

from ameba.

veelenga avatar veelenga commented on May 27, 2024

Closed by

#248

from ameba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.