Comments (6)
Ideally, ameba shouldn't depend on libcrypto. A native Crystal implementation would be much easier and avoid an unnecessary dependency. Stdlib currently has no crypographic hash algorithm implemented in native Crystal, though.
But the only use of Digest
in ameba is this:
Line 210 in f288cc3
I'm pretty sure an internal checksum for recognizing duplicates does not need a cryptographic hash.
String#hash
should suffice for that.from ameba.
@tjbarber i don't think it is related to M1 / macOS 12.6. I have the same setup and it compiles successfully on my end.
from ameba.
That's a problem with your crystal installation, there's nothing to do here from the ameba's side.
from ameba.
@tjbarber It looks like you're either missing libcrypto or the version you have installed is incompatible. You can get assistance for this problem at https://forum.crystal-lang.org/ or in one of the community chats (https://crystal-lang.org/community/#chat).
from ameba.
@veelenga @Sija The problem is likely caused by a missing lib dependency.
But there's actually no mention in the installation instructions that ameba requires libcrypto. It does so by using Digest::SHA1
which is based on OpenSSL. So it's not a direct dependency, but through stdlib. Still, libcrypto is an optional dependency for stdlib and applications that use it should better mention that for complete installation instructions.
from ameba.
@straight-shoota Good catch, thanks! We definitely shouldn't depend on libcrypto, I can prepare a PR fixing that.
ftr, this dependency was silently introduced in #248.
from ameba.
Related Issues (20)
- `--only` CLI flag appears to ignore excluded files within config HOT 1
- BUG: trying to downcast (Slice(UInt8) | Nil) (Crystal::MixedUnionType) <- Slice(UInt8) (Crystal::GenericClassInstanceType) (Exception) HOT 2
- `Lint/LiteralsComparison`: false positive when comparing tuple
- Failing spec on crystal master
- Replace `Performance/AnyInsteadOfEmpty` with `Style/EmptyInsteadOfPresent` HOT 9
- Regression in `Lint/ShadowingOuterLocalVar`
- Configure skipping directories HOT 3
- warn on redundant use of `.try` HOT 3
- Recognize unused variable from type declaration HOT 2
- ComparisonToBoolean with Bool unions HOT 2
- exception names are too limited HOT 7
- A dedicated `rules` command HOT 1
- `Lint/UselessAssign` reports type declarations within `lib` definitions
- Add lsp server option HOT 1
- `Lint/UselessAssign` when using generics HOT 9
- `Lint/UselessAssign` reports macros accepting `Crystal::Macros::TypeDeclaration` HOT 16
- Avoid annoyance from new rules HOT 4
- Naming/BlockParameterName + stdlib methods like sort HOT 4
- spec helpers getting flagged HOT 1
- Custom macro generates "Useless assignment to variable" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ameba.