Code Monkey home page Code Monkey logo

Comments (6)

straight-shoota avatar straight-shoota commented on June 21, 2024 2

Ideally, ameba shouldn't depend on libcrypto. A native Crystal implementation would be much easier and avoid an unnecessary dependency. Stdlib currently has no crypographic hash algorithm implemented in native Crystal, though.

But the only use of Digest in ameba is this:

checksum = Digest::SHA1.hexdigest(source.code)

I'm pretty sure an internal checksum for recognizing duplicates does not need a cryptographic hash. String#hash should suffice for that.

from ameba.

veelenga avatar veelenga commented on June 21, 2024 1

@tjbarber i don't think it is related to M1 / macOS 12.6. I have the same setup and it compiles successfully on my end.

from ameba.

Sija avatar Sija commented on June 21, 2024

That's a problem with your crystal installation, there's nothing to do here from the ameba's side.

from ameba.

straight-shoota avatar straight-shoota commented on June 21, 2024

@tjbarber It looks like you're either missing libcrypto or the version you have installed is incompatible. You can get assistance for this problem at https://forum.crystal-lang.org/ or in one of the community chats (https://crystal-lang.org/community/#chat).

from ameba.

straight-shoota avatar straight-shoota commented on June 21, 2024

@veelenga @Sija The problem is likely caused by a missing lib dependency.
But there's actually no mention in the installation instructions that ameba requires libcrypto. It does so by using Digest::SHA1 which is based on OpenSSL. So it's not a direct dependency, but through stdlib. Still, libcrypto is an optional dependency for stdlib and applications that use it should better mention that for complete installation instructions.

from ameba.

Sija avatar Sija commented on June 21, 2024

@straight-shoota Good catch, thanks! We definitely shouldn't depend on libcrypto, I can prepare a PR fixing that.

ftr, this dependency was silently introduced in #248.

from ameba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.