cryptowatch / cw-sdk-go Goto Github PK

Hi,

Is this SDK still maintained? there are a lot of old and libs required in your go.mod and there hasn't been a single update since 2019.

To me this smells like an abandoned repo. Is there any plan on updating the dependencies?

The issue with dependencies boils down to mainly gorilla/websockets which might be used in a plethora of other exchanges making this sdk impossible to be used with other sdks that also use websocket as the versions diverge and go wont allow compiling it.

Hi,

I've noticed that from common/trading the StopLossLimitOrder order type name is missing from the OrderTypeNames map.
Is nothing major but I thought I would tell.

Regards

Out of box make command brings quite aa few of error messages like
client/rest/rest.go:12:2: cannot find package "code.cryptowat.ch/cw-sdk-go/common"... ...

After manually issuing
go get command for 13 packages ran make again and got the following error message:
client/websocket/ws_conn.go:13:2: use of internal package code.cryptowat.ch/cw-sdk-go/client/websocket/internal not allowed

go version go1.11.4

Hello!

I'm wondering is it possible to get a list of instruments from the CryproWatch API? or using this SDK?
I didn't find any information in docs but I found some info in your latest unreleased version of SDK:

I was thinking instruments are using to get aggregated data from many exchanges for example to have trades streams.

The bid and ask results are divided between the labels "base" and "quote". What do they mean?

Hi,

If I create a streamClient with an orderbook subscription to an instrument spread there is a couple of things I realized in the marketUpdate regarding their timestamps.
For example, if you have a market X then you will get all the updates of market X in chronological order but sometimes the timestamp doesn't change as can be seen in this recorded data for market ID 62079 in line 22 and 90(
book_new_release.txt

The other thing is that there is a high chance that an update from market Y that happened before market X update will arrive later as can be seen in almost every update in the recorded data, but maybe this is the expected behaviour since neither deltas arrive in order.

Another thing that happened to me is that sometimes these timestamps are from 1970(you can find examples for this as well. These are always from exchange: 65)

These all occurred to me with the official release and with the latest beta release as well.
Can you provide me with a reason for any of these events, please? Especially I'm interested in a way to handle the invalid 1970 timestamps and to handle the non-changing timestamp.

All the bests,

Mark

According to API there should be more parameters available for the requests, a few that I've spotted:
https://docs.cryptowat.ch/rest-api/markets/trades
func (c *RESTClient) GetTrades( exchangeSymbol string, pairSymbol string, ) ([]common.PublicTrade, error)

https://docs.cryptowat.ch/rest-api/markets/order-book
func (c *RESTClient) GetOrderBook( exchangeSymbol string, pairSymbol string, ) (common.OrderBookSnapshot, error)

https://docs.cryptowat.ch/rest-api/markets/ohlc
func (c *RESTClient) GetOHLC( exchangeSymbol, pairSymbol string, ) (map[common.Period][]common.Interval, error)

Alternatively, the requestwith fields and do method should be exported so that clients can extend this as needed.

Hello,

There is a problem with the v2 code.
Basically you do not follow go convention on major versions and module paths.

This is unfortunate because it prevents go mod to include the library with this tag, see below :

go get code.cryptowat.ch/[email protected]

code.cryptowat.ch/[email protected]: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

Of course, I can always use the commit hash to force the version like this

go get code.cryptowat.ch/cw-sdk-go@bba79f5fb34fa3d3a3948c6403199c190213efd2
go: code.cryptowat.ch/cw-sdk-go bba79f5fb34fa3d3a3948c6403199c190213efd2 => v1.0.3-0.20200521131807-bba79f5fb34f
go: downloading code.cryptowat.ch/cw-sdk-go v1.0.3-0.20200521131807-bba79f5fb34f

But this solution is obviously far from ideal.

Is there a fix planned ?

Regards