Code Monkey home page Code Monkey logo

defi-wallet-core-rs's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

defi-wallet-core-rs's Issues

Problem: missing design of rpc client facade

cosmos clients are divided into 3 categories(different port)

design the main api facade for handling different port

the gRPC server (default port: 9090),
the REST server (default port: 1317),
the Tendermint RPC endpoint (default port: 26657)

Problem: k256 may not have received an independent audit

Problem: missing function of wallet verification for NFT

add api for wallet verification
whether specific address is truly belongs to the user
after that, user can fetch his NFT from server

to prevent replay attack, input should be random or given by the server.
refer to related ethereum NFT protocols

Problem: Android and iOS CI actions take a long time

Android build takes from 30 to 60 minutes: https://github.com/crypto-com/defi-wallet-core-rs/actions/workflows/android-build.yml
iOS build takes about 15 minutes: https://github.com/crypto-com/defi-wallet-core-rs/actions/workflows/ios-build.yml

there are currently a few obvious optimisations that could dramatically reduce this time:

  1. there's no need to run cargo build... in the whole workspace -- Android and iOS only need the defi-wallet-core-common crate to be built... so running cargo build -p defi-wallet-core-common ... will speed up things
  2. there are some repeated steps that download or build the same dependencies, e.g. openssl, uniffi_bindgen... these can be cached: https://docs.github.com/en/actions/advanced-guides/caching-dependencies-to-speed-up-workflows

Problem: cannot get address from index in wallet

pub fn get_default_address(&self, coin: WalletCoin) -> Result<String, HdWrapError> {

only returns index=0

add this api to wallet
pub fn get_address(&self, coin: WalletCoin,index:i32) -> Result<String, HdWrapError> {

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.