The pandorasbox from cruor

DrivableCar Bugs

Audio.Play should be inside HitSpring, otherwise the audio will play each frame

Lines 244 to 251 in a9e1f16

    
           foreach (Spring spring in scene.Entities.Where(e => e is Spring)) 
        
           { 
        
               if (this.CollideCheck(spring)) 
        
               { 
        
                   Audio.Play("event:/game/general/spring", this.BottomCenter); 
        
                   HitSpring(spring); 
        
               } 
        
           }

When speed.X happens to be exactly 0, then facing will be 0, so sprites.scale.X = 0, which make sprites disappear

PandorasBox/Entities/DrivableCar.cs

Lines 113 to 124 in a9e1f16

    
           private void HitSpring(Spring spring) 
        
           { 
        
               if (this.springDelay == 0) { 
        
                   this.speed.Y -= spring.Orientation == Spring.Orientations.Floor ? 240f : 140f; 
        
                   this.speed.X += spring.Orientation == Spring.Orientations.WallRight ? -180f : (spring.Orientation == Spring.Orientations.WallLeft ? 180f : 0); 
        
                   this.facing = Math.Sign(this.speed.X); 
        
                   this.springDelay = this.springGrace; 
        
                   this.springMethod.Invoke(spring, null); 
        
               } 
        
           }

Either we should check invincibility in OnCollideH, or we should check crashed when updating nitroActive
Currently if we enable invincibility, car crashes, then we (still on car) can no longer change the direction, but we can still press dash to make the car move, that's really weird

PandorasBox/Entities/DrivableCar.cs

Lines 352 to 362 in a9e1f16

    
           private void OnCollideH(CollisionData data) 
        
           { 
        
               if (Math.Abs(speed.X) > this.maxSpeed * 0.85) 
        
               { 
        
                   this.crashed = true; 
        
                   this.talker.Visible = false; 
        
                   if (driver != null && !driver.Dead) 
        
                   { 
        
                       driver.Die(Vector2.Zero); 
        
                   }

PandorasBox/Entities/DrivableCar.cs

Lines 292 to 309 in a9e1f16

    
           private void updateSpeed() 
        
           { 
        
               this.speed.Y = Calc.Approach(this.speed.Y, 200f, 400f * Engine.DeltaTime); 
        
               // Madeline is not "in" the car yet 
        
               if (this.enterDelay > 0) 
        
               { 
        
                   return; 
        
               } 
        
               this.nitroActive = driver != null && !driver.Dead && this.currently_driving && Input.Dash && this.nitroDuration > Engine.DeltaTime; 
        
               // Nitro is allowed in air, but can only go forward 
        
               if (this.nitroActive) 
        
               { 
        
                   float newSpeed = this.speed.X + this.facing * this.nitroAcceleration * Engine.DeltaTime; 
        
                   this.speed.X = MathHelper.Clamp(newSpeed, -this.maxSpeed, this.maxSpeed); 
        
               }

If we have upward speed, and we don't press dash, then there's no speed clamp in updateSpeed, ok that sounds reasonable
but hitting a left wall spring gives us upward speed and speed.X += 180f, so we will get speed.X = 564 after hitting such a spring
in this case if we hit a right wall spring, our speed will be 384 > maxSpeed * 0.85, so we will still crash into right wall!
maybe we should rewrite HitSpring to ensure that, if we hit a right wall spring, then our speed will be atmost 0 (or maybe atmost -180)

PandorasBox/Entities/DrivableCar.cs

Lines 312 to 315 in a9e1f16

    
           if (!(this.speed.Y >= 0 && this.speed.Y <= Calc.Approach(0f, 200f, 400f * Engine.DeltaTime))) 
        
           { 
        
               return; 
        
           }

cruor / pandorasbox Goto Github PK

pandorasbox's People

Contributors

Stargazers

Watchers

Forkers

pandorasbox's Issues

DrivableCar Bugs

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	foreach (Spring spring in scene.Entities.Where(e => e is Spring))
	{
	if (this.CollideCheck(spring))
	{
	Audio.Play("event:/game/general/spring", this.BottomCenter);
	HitSpring(spring);
	}
	}

	private void HitSpring(Spring spring)
	{
	if (this.springDelay == 0) {
	this.speed.Y -= spring.Orientation == Spring.Orientations.Floor ? 240f : 140f;
	this.speed.X += spring.Orientation == Spring.Orientations.WallRight ? -180f : (spring.Orientation == Spring.Orientations.WallLeft ? 180f : 0);

	this.facing = Math.Sign(this.speed.X);

	this.springDelay = this.springGrace;
	this.springMethod.Invoke(spring, null);
	}
	}

	private void OnCollideH(CollisionData data)
	{
	if (Math.Abs(speed.X) > this.maxSpeed * 0.85)
	{
	this.crashed = true;
	this.talker.Visible = false;

	if (driver != null && !driver.Dead)
	{
	driver.Die(Vector2.Zero);
	}

	private void updateSpeed()
	{
	this.speed.Y = Calc.Approach(this.speed.Y, 200f, 400f * Engine.DeltaTime);

	// Madeline is not "in" the car yet
	if (this.enterDelay > 0)
	{
	return;
	}

	this.nitroActive = driver != null && !driver.Dead && this.currently_driving && Input.Dash && this.nitroDuration > Engine.DeltaTime;

	// Nitro is allowed in air, but can only go forward
	if (this.nitroActive)
	{
	float newSpeed = this.speed.X + this.facing * this.nitroAcceleration * Engine.DeltaTime;
	this.speed.X = MathHelper.Clamp(newSpeed, -this.maxSpeed, this.maxSpeed);
	}

	if (!(this.speed.Y >= 0 && this.speed.Y <= Calc.Approach(0f, 200f, 400f * Engine.DeltaTime)))
	{
	return;
	}