criteo-cookbooks / choregraphie Goto Github PK

Can we get this fixed?

  ArgumentError
  -------------
  tried to create Proc object without a block

  Relevant File Content:
  ----------------------
  /var/cinc/cache/cookbooks/choregraphie/libraries/dsl.rb:

    1:  module Choregraphie
    2:    module DSL
    3:      # DSL helper
    4:      def choregraphie(name)
    5>>       Choregraphie.add(Choregraphie.new(name, &Proc.new))
    6:      end
    7:    end
    8:  end
    9:

  System Info:
  ------------
  chef_version=17.9.26
  platform=centos
  platform_version=7.8.2003
  ruby=ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-linux]
  program_name=/opt/cinc/bin/cinc-client
  executable=/opt/cinc/bin/cinc-client

it is not possible to write:

on /important/'

if there is a resource whose name has a comma (file[important file, do not rename this resource] for instance)

Reason is that we explore resource collection using resource_collection.find which has a special interpretation of commas.

See https://github.com/chef/chef/blob/bb70d7919eba05693bcc4a161503bae52255aa91/lib/chef/resource_collection/resource_set.rb#L159

Here is a proposal implementation:

• Based on the current consul lock primitive mechanism
• If choregraphie is of type "rack" add a field rack to the value
  {"version":1,"concurrency":30,"holders":{},"rack":""}
• Take lock if rack empty or node rack is the same than the one in the rack field and number of holders < concurrency
• During lock release:

1. Remove host entry in the holders hash
2. If holders empty set rack field to an empty string

This will ensure that protected resources are only executed on node in the same rack at a time but it won't ensure that all nodes from a rack are up to date before to update an other rack. It also permitts to have a max number of nodes in the same rack being updated in //.

Thanks to let me know your thoughts