Code Monkey home page Code Monkey logo

Comments (10)

dsbilling avatar dsbilling commented on July 20, 2024 3

Got the same issue here 👍🏻

from prettier_action.

jimmy927 avatar jimmy927 commented on July 20, 2024 1

solved in creyD/[email protected]

from prettier_action.

creyD avatar creyD commented on July 20, 2024 1

@markstos Please try with the new version 4.3, if @jimmy927 is right, we can close this ticket.

from prettier_action.

markstos avatar markstos commented on July 20, 2024 1

@brandart works with me. So this "works for me", too. Thanks!

from prettier_action.

markstos avatar markstos commented on July 20, 2024

This can be debugged by forking the project and modifying -x to the "set" command at the top of entrypoint.sh:

https://github.com/creyD/prettier_action/blob/master/entrypoint.sh#L4

That will print out every bash command before it is executed, which should reveal what file is not found.

from prettier_action.

markstos avatar markstos commented on July 20, 2024

Probably the first thing that the entrypoint.sh should do when it starts is to check to make sure that all the binaries it requires from the host are present, and print an out an error and exit if they aren't find. git, npm and prettier are requirements from the host that are currently all assumed to be present.

Better not to assume anything about the host environment.

from prettier_action.

lnxd avatar lnxd commented on July 20, 2024

It looks like a possible solution from the user's perspective for this issue would be to use absolute paths as I mentioned in #94 (comment). There's something funny going on with relative paths.

from prettier_action.

brandart avatar brandart commented on July 20, 2024

@markstos Please try with the new version 4.3, if @jimmy927 is right, we can close this ticket.

it works with 4.3 👍 thanks :)

from prettier_action.

brandart avatar brandart commented on July 20, 2024

seems like I was wrong and thought that I ran the prettier action (which was comment out) but in the end, I ran the normal prettier. When trying it again it still fails with the same error message.

So I think this issue is not fixed then. :(

from prettier_action.

whoabuddy avatar whoabuddy commented on July 20, 2024

Linking what might be related issues, based on either the prettier executable not being found or a missing plugin causing failure. Are these the same environment issues?

For our use case (see this comment) we were looking to fail on check for a subfolder, everything is working locally but the action fails because it cannot find prettier.


UPDATE: upgraded to 4.3 after reading through some other comments and it now recognizes prettier in the action. It's still not working though, locally I see one file that isn't formatted correctly, but the action reports 0 files.

Does the action respect the local config files in the repo? Confused at why it's so tough just to run a check on a subfolder, more details in this PR comment: https://github.com/casey/ord/pull/1594#issuecomment-1439923087

from prettier_action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.