Comments (8)
This happens because someone might not have the node_modules in gitignore. Will add an option "clean_node_folder" which defaults to True, but if you need it, you can disable it from the next version onwards.
from prettier_action.
I think node_modules
normally should be in .prettierignore
, and if they are not, there's probably a reason for that.
That's 2 layers of protection already, and I don't really see the need for the 3rd one.
(Or you could do git checkout -- node_modules
, but still I think presuming what the users want do to is not a good policy).
from prettier_action.
I agree, just don't want to change functionality if someone uses it like that. Could you please check against prettier_action@dev to verify the new option is working?
from prettier_action.
Looks good.
from prettier_action.
Had issues with this as well, took a some time to debug why my workflow was failing.
I agree, just don't want to change functionality if someone uses it like that.
Consider switching to semantic versioning for this package so its easier to introduce breaking changes like this. E.g. with release-please
from prettier_action.
@jorgenbs I thought what I was doing is semantic versioning. v4.3 introduces this change, see changelog, v4.2 was the previous version.
from prettier_action.
@burner1024 Do you consider this bug fixed?
from prettier_action.
Yes, sure.
from prettier_action.
Related Issues (20)
- [BUG] Problem running prettier in workflow HOT 5
- [BUG] Doesn't fail on infer parser failed HOT 4
- [BUG] Actions Fails to install/use modules - Cannot find module '@prettier/plugin-php'
- [BUG] Cannot find module 'prettier-plugin-tailwindcss' HOT 11
- [BUG] `prettier` not installed correctly HOT 9
- [BUG] prettier: command not found HOT 3
- [BUG] Problem --writer HOT 4
- [BUG] Process completed with exit code 1 HOT 5
- [BUG] Example not working. HOT 4
- IDEA: Add push_options parameter HOT 3
- [BUG] Error: Process completed with exit code 1 when using prettier-php HOT 12
- [BUG] Code style issues found, can't reproduce locally HOT 2
- [FEATURE] Format only changed lines not the whole file HOT 1
- [BUG] Should work when package-lock.json is not versioned HOT 3
- [FEATURE] Don't log unchanged files
- [BUG] Dry run fails in spite of the fact that a line length does not exceed 80 chars. HOT 2
- What is status code 128? HOT 5
- Readme out of date
- [FEATURE] Print the `prettier` command to be executed before executing it
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier_action.