[FEATURE] Use repo prettier configuration. about prettier_action HOT 7 OPEN

I'm having a similar issue where it seems like this action isn't respecting my .prettierignore and .prettierrc files. What should the prettier_options be if I want Prettier to use those configurations? Assuming they are at the base of my repo.

from prettier_action.

Oh, you are ignoring the .prettierignore file, that's why you are getting some problems about unknown file formats. remove the ignore-path flag and you're good to go.

from prettier_action.

Taking this a step further, would it be possible to use the repo's installed version of prettier? Its easy for the prettier_version value to get out of sync with what is actually installed in the repo which can cause formatting differences.

from prettier_action.

I'v actually test it and it does.
And i check the entrypoint.sh and it is using repo config file. It just have to follow prettier docs indications.

from prettier_action.

That would be a good idea! We don't have this in place yet, I always do it via the prettier_options using your path --config app/.prettierrc parameter. But we could integrate this.

from prettier_action.

@creyD I don't want to hijack this request but I'm having a similar question regarding the use of the .prettierignore file. How do I pass it to the action? The --ignore-path "./.prettierignore" parameter doesn't seem to work because the action throws the following errors:

Error:  No parser could be inferred for file: x/y/assets/[email protected]
Error:  No parser could be inferred for file: x/y/assets/[email protected]
Error:  No parser could be inferred for file: x/y/assets/[email protected]
Error:  No parser could be inferred for file: x/y/assets/[email protected]

My prettierignore looks like this:

(...)
x/y/*.png
(...)

Workflow yaml:

      - name: Check Code Formatting
        uses: creyD/[email protected]
        with:
          # only_changed: true
          dry: true
          prettier_options: --write x/y/**/* --ignore-path "./.prettierignore"

As a workaround, I'll just add the filetypes to the --write parameter.

from prettier_action.

@johannbotha I suppose --ignore-path .prettierignore --config .prettierrc would be sufficient. But it would be very cool if we could include this in the future.

from prettier_action.