crescentrose / sunshine Goto Github PK

Thank you for this fantastic little tool. Works great on macOS with CoreLocation. Have already implemented it in a little script of my own. (Will post the link once it's up.)

Two little suggestions. The more important one would be a --floating option, i.e. don't show the sunrise and sunset for the current date, but show the previous event and the next two events, depending on the time of day. So at noon (while light) it would look like…

last sunrise: <time today>
next sunset: <time today>
next sunrise: <time tomorrow>

… and e.g. shortly after midnight (while dark) it would look like…

last sunset: <time yesterday>
next sunrise: <time today>
next sunset: <time today>

The second suggestion (less important) would be the --apparent option to calculcate not the astronomical times of sunrise and sunset, but the times of the apparent sunrises and sunsets. (Due to light refraction in the atmosphere, apparent sunset is a little later than the real sunset, and apparent sunrise is a little earlier than real sunrise.)

When trying sunshine '#North Pole' and sunshine #South Pole, there's a thread 'main' panicked at 'invalid or out-of-range datetime' error.

Same when trying the coordinates: sunshine '@90.0 0.0' and sunshine '@-90.0 0.0

A suggestion for an additional option, e.g. --day.

Would return success if true, and error if false. For stuff like: sunshine --day &>/dev/null && echo "day" || echo "night"

net2 crate has been deprecated; use socket2 instead

The net2 crate has been deprecated
and users are encouraged to considered socket2 instead.

See advisory page for additional details.

Suggestion: add a --remote option to display the times of sunrise & sunset not with the local time at the location of the querying user, but with the remote time instead, i.e. with the local time at the queried location. (Would probably have to add a trailing time zone string.)

The easiest thing could be a --utc option… then the user can convert the date himself.

(Or both.)