Code Monkey home page Code Monkey logo

musicbrainzpicardplugin_firstrecorded's People

Contributors

craigshelley avatar

Stargazers

BAAMN avatar  avatar Zhiro90 avatar Jerzerak avatar

Watchers

James Cloos avatar  avatar  avatar  avatar

Forkers

ag-eitilt

musicbrainzpicardplugin_firstrecorded's Issues

AttributeError thrown when looking up standalone recordings

When trying to look up a track without an associated release ID (i.e. one under "[non-album tracks]"), the plugin throws the following error. This also causes the processing of that track to stop with "[loading track information]" displayed and the proper "Unmatched file" unassigned, until something else causes Picard to update the list. At that point, the track is displayed correctly, but the file remains separate.

E: 00:32:54 Traceback (most recent call last):
  File "picard\track.pyo", line 267, in _recording_request_finished
  File "picard\track.pyo", line 277, in _parse_recording
  File "picard\metadata.pyo", line 341, in run_track_metadata_processors
  File "picard\plugin.pyo", line 479, in run
  File "C:\Users\█████\AppData\Roaming\MusicBrainz\Picard\plugins\firstrecorded.py", line 92, in first_year_track
  File "C:\Users\█████\AppData\Roaming\MusicBrainz\Picard\plugins\firstrecorded.py", line 86, in mydolookup
  File "picard\webservice.pyo", line 97, in __getattr__
AttributeError: recording

The relevant code includes:

84:     def mydolookup(self):
85:         self.album._requests+=1
86:         self.album.tagger.xmlws._get_by_id('recording', self.track_node.recording[0].id, self.myhandler, ['releases']);
87:
88:
89:
90: def first_year_track(album, metadata, track_node, release_node):
91:     mylookup=MyLookup(album, metadata,track_node, release_node)   
92:     mylookup.mydolookup()

"Unknown date format" on parse attempt

The main thing keeping this plugin from working seems to be an issue with datetime.strptime; the log fills with messages similar to the below.

D: 00:22:56 	Date=1987-03-23
I: 00:22:56 ERROR: Unknown date format dtstrmin='1987-03-23' dtstrmax='1987-03-23' for Recording ID: 825e153f-3fc7-4825-addd-87d430ba7248

For reference, the issue seems to stem from lines 61 and 62.

dtobjmin=datetime.strptime(dtstrmin, '%Y-%m-%d')
dtobjmax=datetime.strptime(dtstrmax, '%Y-%m-%d')

Relicense to GPL2+?

Any chance you can change the license for the plugin to be "GPL version 2 or, at your discretion, any later version"? Picard itself may need to switch to GPL 3(+) for the Picard 2.0 code (due to a license change in one of the dependencies), and thus plugins may also need to change to a compatible license for this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.