craftykate / jammming Goto Github PK

I think the best of both worlds would be to clear the input area after every search but display in the Results column the search term used.

This is a pretty sound conclusion. Often times, the best UI is the most minimal UI.

That being said, a clear form icon/button would be pretty minimal and maybe offer the user more control. Is it worth it?

There are no objectively right or wrong approaches, just different tradeoffs to consider and you're definitely doing your due diligence and thinking about this problem thoroughly 👍

So first a couple screenshots

Console Errors below

The first one is the more important one. I had notice that you are using

scope=playlist-modify-private

The problem here is that you need additional scoping in this case.

playlist-read-private

https://developer.spotify.com/web-api/using-scopes/

I don't see that being requested and I think that it is needed.

The project was built with the idea that

playlist-modify-public would be used because there is no additional scoping needed since public playlists are meant to be open to all.

Overall met expectations.

Interesting that you made separate functions for the fetch Get and the fetch Post requests. Good job in doing that, I think it is clearer in some regards.

Code overall was well structured and readable. I saw no major issues. The issue I did mention is a common one when using private playlists.

Include inside App.search():
sessionStorage.setItem("inputSearch", searchTerm);

Excellent job researching a (possibly) new, unfamiliar API. This skill will take you far as a developer 🔥

If there’s no access token the window will redirect, the new url will contain the access token, and the App component will mount again. If there is a valid access token the App component will not mount again. So it makes sense to check to see if the window has been redirected only after the App component has mounted.

Impressive use of React's lifecycle methods here! 💯

You're demonstrating quite the intuition for using your available tools creatively. Keep it up! 👍

The app should remember the search term inputted by the user so it can automatically perform the search if the screen has been redirected on login.

This is a great feature to propose 👍

Any feature that saves a user time and helps them achieve their purpose more easily is worth proposing and implementing.