craftminecraft / bungeeyaml Goto Github PK

One problem that has plagued the bukkit configuration API has been the use of comments in yaml due to snakeYAML being unable to write out comments when the configuration is modified.

Adding an additional commenting engine would allow BungeeYAML to not just be a port of the bukkit configuration api, but be an improved stand-alone version of it.

Every time I start my proxy with the BungeeBan Plugin that uses this "Library" an empy new line is inserted at the beginning of the config file.

# BungeeBan Main Config


storagetype: mysql
....

The new empty line is inserted after the first comment "# BungeeBan Main Config".

Config.java:75 - When the loop went through it adds an additional new line char.
But if there is already a new line char, then ... aah you understand what i mean...

for(String line : CONFIG_HEADER.split("\n")) {
       newConfig.write("# "+line+"\n");
}

Because you already add a new line if there is already one in YAMLConfiguration:42-45

        StringBuilder builder = new StringBuilder(buildHeader());
        if (builder.length() > 0) {
            builder.append('\n'); // newline after header, if present.
        }