cpdean / cargo-danger Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 1.0 44 KB

cargo utility

Rust 100.00%

cargo-danger's People

Contributors

Stargazers

Watchers

Forkers

gs0510

cargo-danger's Issues

error reporting on gotham, webframework

I've messed something up about parsing a project's toml

thread 'main' panicked at 'dunno Compat { error: ErrorMessage { msg: "manifest path `/home/conrad/dev/foss/rust/gotham/Cargo.toml` is a virtual manifest, but this command requires running against an actual package in this workspace" }

stack backtrace:
   0: failure::backtrace::internal::InternalBacktrace::new::he4986608efdde9fc (0x5560215473ef)
   1: failure::backtrace::Backtrace::new::h5b4f19a770bab8b5 (0x55602154768f)
   2: cargo::core::workspace::Workspace::current::he0946466ad956eb3 (0x55602131946e)
   3: cargo_danger::main::hcdca0f7decce5456 (0x55602106dc9a)
   4: std::rt::lang_start::{{closure}}::hf6979feb6dd869b6 (0x55602104d632)
   5: std::rt::lang_start_internal::{{closure}}::hdfc28107b5be47c9 (0x556021573ad2)
             at src/libstd/rt.rs:59
      std::panicking::try::do_call::h69790245ac2d03fe
             at src/libstd/panicking.rs:310
   6: __rust_maybe_catch_panic (0x556021587699)
             at src/libpanic_unwind/lib.rs:102
   7: std::panicking::try::h9c1cbc5599e1efbf (0x556021574563)
             at src/libstd/panicking.rs:289
      std::panic::catch_unwind::h0562757d03ff60b3
             at src/libstd/panic.rs:398
      std::rt::lang_start_internal::h540c897fe52ba9c5
             at src/libstd/rt.rs:58
   8: main (0x556021073231)
   9: __libc_start_main (0x7ff05a6a7b96)
  10: _start (0x5560210489d9)
  11: <unknown> (0x0) }', /home/conrad/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-danger-0.2.1/src/main.rs:57:17
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:211
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:491
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:398
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:353
   7: cargo_danger::main
   8: std::rt::lang_start::{{closure}}
   9: std::panicking::try::do_call
             at src/libstd/rt.rs:59
             at src/libstd/panicking.rs:310
  10: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:102
  11: std::rt::lang_start_internal
             at src/libstd/panicking.rs:289
             at src/libstd/panic.rs:398
             at src/libstd/rt.rs:58
  12: main
  13: __libc_start_main
  14: _start

rewrite CLI layer to clap or whatever's popular now

There's some by-hand grossness handling the CLI layer of the utility. This leaves fancy cli args and usage docs needing some major attention.

Why clap?

easier to read code
can have more interesting cli arg options
better presentation of end-user docs

Make cli more informative on projects with no packages

It prints some things that are kind of distracting at the moment.

0 - ❯❯❯ RUST_BACKTRACE=1 cargo-danger
[/home/conrad/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-danger-0.2.1/src/main.rs:43] "got some packages" = "got some packages"

`cargo danger` broken where `cargo-danger` works

I think something about how cargo invokes a subcommand matching cargo-* causes it to have a different argv.

error on iron, webframework

it's picking a rust file up with a syntax error?

thread 'main' panicked at 'dunno Error { start_span: Span, end_span: Span, message: "LexError" }', /home/conrad/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-danger-0.2.1/src/main.rs:57:17
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:211
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:495
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:398
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:353
   7: cargo_danger::main
   8: std::rt::lang_start::{{closure}}
   9: std::panicking::try::do_call
             at src/libstd/rt.rs:59
             at src/libstd/panicking.rs:310
  10: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:102
  11: std::rt::lang_start_internal
             at src/libstd/panicking.rs:289
             at src/libstd/panic.rs:398
             at src/libstd/rt.rs:58
  12: main
  13: __libc_start_main
  14: _start

Line Counting is Not Accurate

Due to some shortcuts in how it counts AST nodes, the quantity of unsafe lines of code does not reflect the lines in the file.

This should be changed to count the set of file lines seen instead of AST nodes.

lexerror on actix-web

i should figure out how to correctly give debug info on error results

thread 'main' panicked at 'dunno Error { start_span: Span, end_span: Span, message: "LexError" }', /home/conrad/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-danger-0.2.1/src/main.rs:57:17
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:211
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:495
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:398
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:353
   7: cargo_danger::main
   8: std::rt::lang_start::{{closure}}
   9: std::panicking::try::do_call
             at src/libstd/rt.rs:59
             at src/libstd/panicking.rs:310
  10: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:102
  11: std::rt::lang_start_internal
             at src/libstd/panicking.rs:289
             at src/libstd/panic.rs:398
             at src/libstd/rt.rs:58
  12: main
  13: __libc_start_main
  14: _start

show the end-user the lines found by danger

syntax error crashes cli on `specs` crate

thread 'main' panicked at 'dunno Error { start_span: Span, end_span: Span, message: "expected `,`" }', /home/conrad/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-danger-0.2.1/src/main.rs:57:17
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:211
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:495
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:398
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:353
   7: cargo_danger::main
   8: std::rt::lang_start::{{closure}}
   9: std::panicking::try::do_call
             at src/libstd/rt.rs:59
             at src/libstd/panicking.rs:310
  10: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:102
  11: std::rt::lang_start_internal
             at src/libstd/panicking.rs:289
             at src/libstd/panic.rs:398
             at src/libstd/rt.rs:58
  12: main
  13: __libc_start_main
  14: _start

cpdean / cargo-danger Goto Github PK

cargo-danger's People

Contributors

Stargazers

Watchers

Forkers

cargo-danger's Issues

error reporting on gotham, webframework

rewrite CLI layer to clap or whatever's popular now

Why clap?

Make cli more informative on projects with no packages

`cargo danger` broken where `cargo-danger` works

error on iron, webframework

Line Counting is Not Accurate

lexerror on actix-web

show the end-user the lines found by danger

syntax error crashes cli on `specs` crate

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent