cotag / angular-safeapply Goto Github PK

"angular-safeapply": "~1.0.4"

Looking at safe-apply.js, this seems to happen here:

if (force || !($scope.$$phase || $scope.$root.$$phase)) {

But I'm not sure whether this is on the first or second $$phase, tempted to think it's $root that's null.

My code does something like

angular.module('...')
.controller('...', ['$scope', ..., function($scope, ...) {
  $scope.init = function() {
    $scope.typeAheadEngine = new Bloodhound({
      remote: {
        ajax: {
          complete: function() {
            $scope.$safeApply(function() { $scope.searching = false; });  // <<== issue here
          },
        },
  ...

I don't have a way to reproduce yet. Any idea what's going on?

TypeError: Cannot read property '$$phase' of null
at h.$rootScope.$safeApply (http://playnex.com:6002/js/lib/safe-apply.js:56:62)
at eval (http://playnex.com:6002/features/player/controller.js:261:20)

I am getting this error in node-webkit environment. Can't figure out if it is related with weird v8 bug. It leads to uncaught error.

Is it better to prevent it by using a try...catch:
try {
if (force || !($scope.$$phase || $scope.$root.$$phase)) {
$scope.$apply ? $scope.$apply(fn) : $scope.apply(fn);
} else {
fn();
}
}
catch (e) {
// just fn() maybe.
}

or should I check for preliminary objects:
if (force || !(($scope && $scope.$$phase) || ($scope.$root && $scope.$root.$$phase))) {
$scope.$apply ? $scope.$apply(fn) : $scope.apply(fn);
} else {
fn();
}