costezki / fingerprinter-ui Goto Github PK

• research what is the standard error handling mechanism in Meteor + FlowRouter
• create the error handling mechanisms in the appropriate places

In the client part of the project, write comments to the functions or declared "ReactiveVar" and "Session" variables.

for each drawback of potential improvement mentioned in the report create a gitHub Issue.

Instead of writing a file to the "Csv" "Collection" and creating a duplicate, you need to use the mdg callback return value to get the download link.

replace MeteorFiles.write to MeteorFiles.addFile

Display information about the "Python" script process to the client.

From the file "validationMethods.js" move functions not pre-designated for export to another file, like «utils.js». Where it will be understood that they are as an addition to "mdg" methods.

on form submit for diff or stats forms, call a server method that generates an arbitrary file (e.g. uui4) and adds it to a file collection.
the file collection then makes it available for download.

Do not use "Session" variables, if possible, and if not, after the "PDF" file was created, delete these "Session" variables.

port the report from pdf to Markdown Wiki page

Stylize the button for uploading files.

test

Combine "Diff" and "Stats" in "SimpleSchema", creating one form and one template, thereby reducing the amount of code and not losing readability and logic.

After downloading the finished "PDF", clear the folder it's unnecessary files.

Create a folder with a unique name, where the files of the current "PDF" generation session will be stored, for easy cleaning after the process.

When a stats or diff form is submitted then write a JSON file with form details and default value for oteher fields according to the example.

{
  "title": "EuroVoc Fingerprint Report - From Old to New and Back",
  "type": "difference between two dataset fingerprints",
  "author": "Eugeniu Costetchi",
  "ns_file": "./resources/prefix.csv",
  "output" : "./out",
  "alpha": {
    "file": "./resources/fingerprint.rq_eurovoc44.log",
    "title": "EuroVoc 4.4",
    "desc": "EuroVoc 4.4 was released a long time ago using EuroVoc Ontology."
  },
  "beta": {
    "file": "./resources/fingerprint.rq_EV45OLD.log",
    "title": "EuroVoc 4.5(bc)",
    "desc": "EuroVoc 4.5 backward compatible (bc) was released in July 2016 with SKOS-AP-EU and then converted to fit also the old profile of EuroVoc Ontology."
  }
}

1. analyse the goal the function needs to achieve
2. write a short pseudo-code of steps in order to achieve the goal
3. implement (re-implement)

Attempt to introduce in the "SimpleSchema" "FileCollection", to download a file from the form.

the download file is not available for download

After generating the "PDF" and downloading it, let the client immediately re-start using the form again, without updating the page.

Upload files from the form only when the submit form was generated, to avoid unnecessary downloads of files.

resolve code upgrade dependencies

after pushing generate-report button

• signal that there is a shall process at work
• any errors from the command line shall be reported back to the client side
• the submit button shall be disabled while the shell process is running

reproduce error by following steps:

1. go to stats page
2. provide a correct csv
3. press submit and wait for the result to arrive
4. press submit again [and here is the exception]

Exception while invoking method 'generateJSON' TypeError: Cannot read property 'value' of undefined
I20170428-16:22:13.463(2)?     at [object Object].ValidatedMethod.run (imports/mdg/validatedMethods.js:44:32)
I20170428-16:22:13.463(2)?     at ValidatedMethod._execute (packages/mdg:validated-method/validated-method.js:93:12)
I20170428-16:22:13.464(2)?     at [object Object].ValidatedMethod.connection.methods._connection$methods.(anonymous function) (packages/mdg:validated-method/validated-method.js:54:23)
I20170428-16:22:13.464(2)?     at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1737:12)
I20170428-16:22:13.464(2)?     at packages/ddp-server/livedata_server.js:719:19
I20170428-16:22:13.464(2)?     at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
I20170428-16:22:13.466(2)?     at packages/ddp-server/livedata_server.js:717:40
I20170428-16:22:13.467(2)?     at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
I20170428-16:22:13.467(2)?     at packages/ddp-server/livedata_server.js:715:46
I20170428-16:22:13.467(2)?     at [object Object]._.extend.protocol_handlers.method (packages/ddp-server/livedata_server.js:689:23)