cosmicmind / algorithm Goto Github PK

Let's leverage instead of re-write Apple collections: https://github.com/apple/swift-collections.git

I want to add these collections by adding swift-collections as a dependency.

Deque<Element>, a double-ended queue backed by a ring buffer. Deques are range-replaceable, mutable, random-access collections.

OrderedSet<Element>, a variant of the standard Set where the order of items is well-defined and items can be arbitrarily reordered. Uses a ContiguousArray as its backing store, augmented by a separate hash table of bit packed offsets into it.

OrderedDictionary<Key, Value>, an ordered variant of the standard Dictionary, providing similar benefits.

In lieu of:

• Deque
• SortedDictionary

There are some build failures when trying to build with Xcode 9 Beta 2, for example:

• 'Collection' requires the types 'Key' and '(key: Key, value: Value?)' be equivalent
• 'Sequence' requires the types 'Key' and '(key: Key, value: Value?)' be equivalent

The project is still set to Swift 3 (3.2).

Is it possible defining a sorting criteria in SortedDictionary? I'm using this data structure but i need to sort elements in order descending directly.

This style comments:

 /**
  :name: removeValueForKey
  :description: Removes a single instance of a value for a key. This is
  important when using non-unique keys.
  - returns: Value?
 */
public func removeInstanceValueForKey(_ key: Key) -> Value? {}

Should be updated to the newer style:

 /**
  Removes a single instance of a value for a key. This is
  important when using non-unique keys.
  - Parameter _ key: A Key.
  - Returns: Removed Value for given key, nil on fail.
 */
public func removeInstanceValueForKey(_ key: Key) -> Value? {}

Data structures should take in a compare function that allows for custom sorting.