Calculation of BLR absorption fails for r = R_line about agnpy HOT 3 CLOSED

Hi, I think this is the same thing which I mentioned in the second paragraph of #86 and this can also get triggered in other cases.
I can make a fix, but there are a few different ways to do it:

1. set the value of integrant to 0 (or some bordering value) for the points where you end up with position ~R_line
2. shift the actual integration points that are ~R_line a bit e.g. 0.1 %)

I think the second solution is probably easier. Any preference?

from agnpy.

I agree, the second solution is easier, and probably also computationally faster.

from agnpy.

added a PR #91 that should solve this.
I also made a fix for the case of mu_s !=1 - in that case we would not end up with nans usually because you would need to hit not only position of R, but also of the angles, but either way if one of integration points lies on the BLR sphere it can make the integration messy so I shifted those points as well.

There might be also an issue with the IC part, I guess it would also have the same problem, but a bit simpler, because you do not integrate over the photon path, so you could have a problem only in r = R_line

from agnpy.