Logging is silently disabled on agnpy import about agnpy HOT 3 OPEN

Hello @pguenth,

thanks for reporting this!
I think this is the only point where I use the logging

Can it be that by re-importing logging here it is setting the logging back to the default level (that should be WARNING or ERROR, right)?
Perhaps adding a
logger = logging.getLogger(__name__)
and then using logger.info("...")
in fit/__init__.py will fix the issue (I think it will import the logger already defined).

from agnpy.

As far as I understand the logging library, this should not make a difference. Just using logging.info() and similar calls (instead of using a particular logger) should just default to some default logger. I will try to think of a test to find out.

from agnpy.

Okay the behavior of the logging module is apparently even more unexpected (at least to me):

The functions debug(), info(), warning(), error() and critical() will call basicConfig() automatically if no handlers are defined for the root logger.

(https://docs.python.org/3/library/logging.html#logging.basicConfig)

So the problem is most likely that agnpy's call to logging.warning() in the file you mentioned implicitely calls logging.basicConfig() with some defaults, which prevents further code (that imports agnpy) to configure the root logger.

The solution you proposed seems to be the best in my opinion (although for a slightly different reason) and is also what the documentation recommends.

from agnpy.