Code Monkey home page Code Monkey logo

Comments (6)

cosimoNigro avatar cosimoNigro commented on July 19, 2024

After removing the dependency on the Blob from the absorption (in PR #76), the case of the dust torus at all distances has improved. In the agnpy comparison now mu_s=1, before mu_s was taken from the blob.
Here some examples, the final check compares against a point source approximating the disk in case of a very large from the BH.
tau_dt_comprison_r_1e-1_R_Ly_alpha_figure_14_finke_2016
tau_dt_comprison_r_1e0_R_Ly_alpha_figure_14_finke_2016
tau_dt_comprison_r_1e1_R_Ly_alpha_figure_14_finke_2016
tau_dt_comprison_r_1e2_R_Ly_alpha_figure_14_finke_2016
tau_dt_point_source_comparison

I would close this, if it's ok with you @jsitarek.
I think we have a decent agreement for this case now.

from agnpy.

jsitarek avatar jsitarek commented on July 19, 2024

the agreement looks very nice, closing

from agnpy.

jsitarek avatar jsitarek commented on July 19, 2024

sorry for reopening it, but I found something strange in DT absorption while investigating the BLR one.
finke_dt_1 03
finke_dt_10
finke_dt_100

if r << R_dt the reference line and the agnpy line are basicaly shifted by a factor very close to 1+z. This is something that we were discussing before, but from the paper it seems that the curves are given in energy at the galaxy, and actually for BLR absorption from the same plot there is a very nice agreeement.

if the emission region is far there starts to be a disagreement between agnpy and Finke's paper.
However I'm not sure of the actual parameters, table3 gives parameters for extended dust torus, while the plot is for point like. I used T=1000K (which is probably fine), and R_dt = 3.5e19 cm (which is the outer DT radius in the table for the extended DT).
@cosimoNigro which parameters have you used in your comparison plots?

from agnpy.

jsitarek avatar jsitarek commented on July 19, 2024

Following the discussion that we had today with @cosimoNigro I updated the plots with the proper R_dt= 1.6e19 cm (using formula 96 from the Finke'16 paper). If the Finke's points are scaled up by a factor of 2 (an issue in that paper that we discussed earlier), and are corrected by redshift of then I get a perfect agreement like Cosimo in his plots. We can close again the issue. However I think it is worth to write to Justin Finke that the BLR and DT absorption points in his Fig 14 seem to be computed w.r.t. different energies (BLR in the source frame, DT in the observer frame).

from agnpy.

cosimoNigro avatar cosimoNigro commented on July 19, 2024

@jsitarek can we close after #89?

from agnpy.

jsitarek avatar jsitarek commented on July 19, 2024

yes, closing...

from agnpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.